Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lucasbru merged PR #15408: URL: https://github.com/apache/kafka/pull/15408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2100868214 This LGTM @cadonna , left comment above discarding one of my messages, the test is clear enough. Only [this](https://github.com/apache/kafka/pull/15408#discussion_r1591300734) other nit

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377324 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1592977058 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

cadonna commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1592700226 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377324 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377060 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591300734 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2056028533 @cadonna could you please review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

kirktrue commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2052100630 @lucasbru—I think it's worth adding the tests, even if we already know there are more to be added in the future. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2049854234 @kirktrue Just because it's meant to be an example, and doesn't cover all combinations. If you want me to merge it like this, we can do that as well. -- This is an automated message

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

kirktrue commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2048153273 @lucasbru—sorry that I've forgotten, but why don't we want to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-1961025640 I'm keeping this around as an example, but I don't intend to merge this. I think we can merge it together with https://issues.apache.org/jira/browse/KAFKA-16111. Converting to a draft.

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

kirktrue commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-1959841458 @lucasbru—Yes, this looks perfect! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-1956664015 @kirktrue Hope that helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific