dajac merged PR #15411:
URL: https://github.com/apache/kafka/pull/15411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on PR #15411:
URL: https://github.com/apache/kafka/pull/15411#issuecomment-2046712467
Re-triggered a build as last one had errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1557562821
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1046,6 +1054,7 @@ object KafkaConfig {
.define(ConsumerGroupMaxHeartbeatIntervalMsProp, INT,
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1554638676
##
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##
@@ -1831,6 +1832,22 @@ class KafkaConfigTest {
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553481594
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/ConsumerGroupMigrationPolicy.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553480909
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -677,6 +679,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsDoc = "The maximum heartbeat
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1553477271
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -248,9 +249,10 @@ object KafkaConfig {
val ConsumerGroupMaxSessionTimeoutMsProp =
dongnuo123 commented on PR #15411:
URL: https://github.com/apache/kafka/pull/15411#issuecomment-2037835825
Will need to add unit tests for the change when group upgrade/downgrade
conversion is finished.
--
This is an automated message from the Apache Git Service.
To respond to the
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1551865511
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -251,6 +252,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsProp
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1551485397
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -251,6 +252,7 @@ object KafkaConfig {
val ConsumerGroupMaxHeartbeatIntervalMsProp
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1542076157
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupProtocolMigrationPolicy.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1539248065
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -279,6 +280,7 @@ object KafkaConfig {
val NewGroupCoordinatorEnableProp = "group.coordinator.new.enable"
dongnuo123 commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1529263591
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupProtocolMigrationConfig.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software
jeffkbkim commented on code in PR #15411:
URL: https://github.com/apache/kafka/pull/15411#discussion_r1503404075
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupProtocolMigrationConfig.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software
dongnuo123 opened a new pull request, #15411:
URL: https://github.com/apache/kafka/pull/15411
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
15 matches
Mail list logo
