Re: [PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]

2024-03-11 Thread via GitHub
wcarlson5 commented on code in PR #15421: URL: https://github.com/apache/kafka/pull/15421#discussion_r1520361134 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java: ## @@ -170,9 +170,6 @@ public void init(final ProcessorContext context,

[PR] KAFKA-16295: Align RocksDB and in-memory store init() sequences [kafka]

2024-02-22 Thread via GitHub
ahmedsobeh opened a new pull request, #15421: URL: https://github.com/apache/kafka/pull/15421 For RocksDB stores, we open the store first and then call #register. However the in-memory store actually registers itself first, before marking itself as open. This change aligns the RocksDB init