showuon merged PR #15557:
URL: https://github.com/apache/kafka/pull/15557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1559170927
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on PR #15557:
URL: https://github.com/apache/kafka/pull/15557#issuecomment-2047083295
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1557584496
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1555305760
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on PR #15557:
URL: https://github.com/apache/kafka/pull/15557#issuecomment-2041535672
I think I've addressed the issues. The failing tests on the most recent
build are unrelated. PTAL @showuon
--
This is an automated message from the Apache Git Service.
To respond to
showuon commented on PR #15557:
URL: https://github.com/apache/kafka/pull/15557#issuecomment-2033422766
There are quite many failed tests because of this change. Could you take a
look?
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15557/4
--
This is an automated message
showuon commented on PR #15557:
URL: https://github.com/apache/kafka/pull/15557#issuecomment-2030993093
There's a compilation error in jdk8_scala2.12:
```
[2024-04-01T13:50:09.625Z] [Error]
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1547006909
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546282044
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546280257
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546269825
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546251867
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546237766
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546237017
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
soarez commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546234986
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546153410
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String,
}
override def
showuon commented on code in PR #15557:
URL: https://github.com/apache/kafka/pull/15557#discussion_r1546078129
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -188,9 +194,52 @@ class ReplicaAlterLogDirsThread(name: String,
}
}
object
18 matches
Mail list logo
