johnnychhsu commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2029543783
@kamalcph thanks for the comment, and sorry for the late reply.
Previously we get the counts from the yammer metrics, however, although the
`onExpire` has called the `mark`, the
showuon merged PR #15463:
URL: https://github.com/apache/kafka/pull/15463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2029068424
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2028125395
> For my understanding, Could you please explain how this patch fixed the
issue? The safeYammerMetricValue was also returning the meter count. Thanks!
@kamalcph the variable of
chia7712 commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1545435135
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
kamalcph commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2027930309
> Instead of getting the number from yammer metrics, we can check the metric
counter and see if it increased
For my understanding, Could you please explain how this patch fixed
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1544639805
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
johnnychhsu commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2027410113
@kamalcph just updated, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r154463
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1460,10 +1460,8 @@ class ReplicaManager(val config: KafkaConfig,
warn("Unable to fetch
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542760219
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
chia7712 commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542616917
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1460,10 +1460,8 @@ class ReplicaManager(val config: KafkaConfig,
warn("Unable to fetch data
kamalcph commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2024392191
@johnnychhsu
Can you update the PR summary if it is ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1542235961
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1541419703
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1538452997
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4164,13 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
johnnychhsu commented on PR #15463:
URL: https://github.com/apache/kafka/pull/15463#issuecomment-2018127603
updated @showuon
it works in my local, thanks for the sharing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
johnnychhsu commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1537571752
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4166,12 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
showuon commented on code in PR #15463:
URL: https://github.com/apache/kafka/pull/15463#discussion_r1534892451
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4164,16 +4166,12 @@ class ReplicaManagerTest {
mock(classOf[FetchDataInfo])
18 matches
Mail list logo
