chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2007459578
@johnnychhsu thanks for this contribution! please complete the follow-up:
1. 3.6 branch has many conflicts so please file a PR for branch 3.6
2. update KIP-734 for the offset of
chia7712 merged PR #15476:
URL: https://github.com/apache/kafka/pull/15476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2007409274
JDK 11 gets cancel. It should be fine as it gets test in previous QA
I run the failed tests on my local:
```sh
./gradlew cleanTest :tools:test --tests
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2005884703
I have rebase the PR to trigger QA again, and I will merge it if no related
failed tests.
--
This is an automated message from the Apache Git Service.
To respond to the message,
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1528497039
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -79,9 +79,34 @@ class ListOffsetsIntegrationTest extends
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1528477660
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -79,9 +79,34 @@ class ListOffsetsIntegrationTest extends
showuon commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1528195441
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -79,9 +79,34 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
showuon commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2003137158
I will take a look later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2002453829
@chia7712 thanks for the reminder.
Below are the failed tests from the build
> [Build / JDK 17 and Scala 2.13 /
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2002394407
@johnnychhsu Could you check the failed tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527123510
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -79,9 +79,34 @@ class ListOffsetsIntegrationTest extends
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-2001881984
test with
```
./gradlew clean core:test --tests kafka.log.LogSegmentTest
./gradlew clean core:test --tests kafka.log.LocalLogTest
```
and it passed
--
This is an
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527119875
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition,
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527119875
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition,
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527116740
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527116473
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -77,11 +77,34 @@ class ListOffsetsIntegrationTest extends
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527041931
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java:
##
@@ -209,7 +209,7 @@ private static FilterResult filterTo(TopicPartition
partition,
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527029580
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1527026867
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -173,9 +173,9 @@ class LogValidatorTest {
assertEquals(now,
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526587744
##
core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala:
##
@@ -82,6 +82,13 @@ class ListOffsetsIntegrationTest extends
KafkaServerTestHarness
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526595161
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526594353
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526591324
##
core/src/test/scala/unit/kafka/log/LogValidatorTest.scala:
##
@@ -404,14 +404,8 @@ class LogValidatorTest {
assertEquals(now + 1,
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-287090
test with
```
./gradlew clean core:test --tests kafka.log.LogValidatorTest
./gradlew clean client:test --tests
org.apache.kafka.common.record.MemoryRecordsBuilderTest
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-237478
thanks @junrao @chia7712 @showuon for the suggestions and comments!
I have updated the following:
- rename the ValidationResult.shallowOffsetOfMaxTimestamp to
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1526268639
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1998570706
@johnnychhsu Could you please rebase code and address following comments.
1. update KIP-734 according to
https://github.com/apache/kafka/pull/15476#discussion_r1523677272
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1523677272
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
showuon commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1522451780
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1522318718
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1522196043
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1521314724
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
johnnychhsu commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1521308393
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
showuon commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1990459827
Please also address this comment in this PR:
https://github.com/apache/kafka/pull/15474#discussion_r1520262997 . Thanks.
--
This is an automated message from the Apache Git Service.
To
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520520996
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520300581
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
jolshan commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1520299410
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
chia7712 commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518449958
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518422852
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518420555
##
core/src/test/scala/integration/kafka/api/OffsetOfMaxTimestampTest.scala:
##
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
junrao commented on code in PR #15476:
URL: https://github.com/apache/kafka/pull/15476#discussion_r1518413083
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -293,11 +293,11 @@ public ValidationResult
assignOffsetsNonCompressed(LongRef
41 matches
Mail list logo
