jolshan merged PR #15524:
URL: https://github.com/apache/kafka/pull/15524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2005610376
I am seeing it fail more often on your branch (for a few runs), but after
merging with trunk, it seemed better. I will go ahead and merge.
--
This is an automated message from the
jolshan commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2004976461
I ran "until failure" on trunk and it took about 30 runs to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
artemlivshits commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2004953080
LogDirFailureTest passed locally as well (probably just a flake) and it
doesn't seem to use any of the code that I touched, so unrelated.
--
This is an automated message from the
jolshan commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2004586672
@artemlivshits it may be worth checking if the test is failing on trunk as
well. If so we can renew the JIRA to fix it
--
This is an automated message from the Apache Git Service.
jolshan commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2004580064
> LogDirFailureTest > testIOExceptionDuringLogRoll(String) has been failing
for a while -- there are some issues I tried to tackle with respect to it, but
we ran into some issues. See
artemlivshits commented on PR #15524:
URL: https://github.com/apache/kafka/pull/15524#issuecomment-2001771301
LogDirFailureTest > testIOExceptionDuringLogRoll(String) >
testIOExceptionDuringLogRoll(String).quorum=kraft is failing locally, will
investigate.
ReplicaManagerTest -- all
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526958117
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class TransactionMarkerChannelManagerTest
artemlivshits commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1526939166
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1525559114
##
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##
@@ -177,6 +178,86 @@ class TransactionMarkerChannelManagerTest
artemlivshits commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1524022035
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##
@@ -109,23 +109,30 @@ object TransactionMarkerChannelManager {
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523937621
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -557,6 +557,7 @@ class TransactionStateManager(brokerId: Int,
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523936892
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala:
##
@@ -90,9 +90,10 @@ class
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523931941
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerRequestCompletionHandler.scala:
##
@@ -39,22 +39,23 @@ class
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523916766
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##
@@ -419,25 +432,34 @@ class TransactionMarkerChannelManager(
def
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523907297
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##
@@ -109,23 +109,30 @@ object TransactionMarkerChannelManager {
}
jolshan commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1523732734
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##
@@ -109,23 +109,30 @@ object TransactionMarkerChannelManager {
}
artemlivshits commented on code in PR #15524:
URL: https://github.com/apache/kafka/pull/15524#discussion_r1521968243
##
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##
@@ -354,41 +366,42 @@ class TransactionMarkerChannelManager(
artemlivshits opened a new pull request, #15524:
URL: https://github.com/apache/kafka/pull/15524
…tate
Now the removal of entries from the transactionsWithPendingMarkers map
checks the value and all pending marker operations keep the value along with
the operation state. This way,
19 matches
Mail list logo
