jolshan commented on PR #15559:
URL: https://github.com/apache/kafka/pull/15559#issuecomment-2064671000
I wonder if I should backport this to 3.7 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jolshan merged PR #15559:
URL: https://github.com/apache/kafka/pull/15559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #15559:
URL: https://github.com/apache/kafka/pull/15559#issuecomment-2019067710
jolshan commented on PR #15559:
URL: https://github.com/apache/kafka/pull/15559#issuecomment-2018411363
Getting a fresh build before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1536046613
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1365,6 +1365,16 @@ object GroupMetadataManager {
def
jolshan commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1536023033
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1365,6 +1365,16 @@ object GroupMetadataManager {
def
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1536004118
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1899,8 +1900,19 @@ public void
dajac commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535973164
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1899,8 +1900,19 @@ public void
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535903580
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -830,7 +830,11 @@ class ReplicaManager(val config: KafkaConfig,
val customException
artemlivshits commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535865337
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -830,7 +830,11 @@ class ReplicaManager(val config: KafkaConfig,
val customException =
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535637194
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535637194
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1535636055
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -831,6 +831,7 @@ class ReplicaManager(val config: KafkaConfig,
error match {
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
squah-confluent commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1534709657
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
artemlivshits commented on code in PR #15559:
URL: https://github.com/apache/kafka/pull/15559#discussion_r1534632389
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -921,7 +921,10 @@ private[group] class GroupCoordinator(
): Unit = {
squah-confluent opened a new pull request, #15559:
URL: https://github.com/apache/kafka/pull/15559
KIP-890 Part 1 introduced verification of transactions with the transaction
coordinator on the `Produce` and `TxnOffsetCommit` paths. This introduced the
possibility of new errors when
18 matches
Mail list logo
