Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-29 Thread via GitHub
chia7712 merged PR #15589: URL: https://github.com/apache/kafka/pull/15589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-28 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r154312 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-28 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1543121911 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +133,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-27 Thread via GitHub
AndrewJSchofield commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1542082131 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,16 +202,14 @@ public static byte[] compress(byte[]

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-27 Thread via GitHub
apoorvmittal10 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1541573651 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +133,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-26 Thread via GitHub
chia7712 commented on PR #15589: URL: https://github.com/apache/kafka/pull/15589#issuecomment-2021800318 @apoorvmittal10 Could you please take a look this PR if ur queue is not full :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-26 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1539400840 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +133,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-26 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1538726557 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +133,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-25 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1537633908 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +132,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-25 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1537626874 ## clients/src/test/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtilsTest.java: ## @@ -132,9 +132,9 @@ public void

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536848215 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
brandboat commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536846618 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,16 +202,14 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536831206 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536831097 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536830823 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -204,17 +202,16 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chiacyu commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789689 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,17 +201,13 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789605 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,17 +201,17 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536789020 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,20 +201,19 @@ public static byte[] compress(byte[] raw,

Re: [PR] KAFKA-16397 - Use ByteBufferOutputStream to avoid array copy [kafka]

2024-03-24 Thread via GitHub
chia7712 commented on code in PR #15589: URL: https://github.com/apache/kafka/pull/15589#discussion_r1536784932 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -203,17 +201,13 @@ public static byte[] compress(byte[] raw,