Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-05-02 Thread via GitHub
philipnee commented on PR #15688: URL: https://github.com/apache/kafka/pull/15688#issuecomment-2090947138 Hi @kirktrue - It was clearly documented why LegacyKafkaConsumer would do this, maybe it is because in some scenarios users want to update the position but actually don't care about

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-10 Thread via GitHub
kirktrue commented on PR #15688: URL: https://github.com/apache/kafka/pull/15688#issuecomment-2048148062 @philipnee—sorry I'm late to the party, but why do we submit the event to the queue when the timeout is 0? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-10 Thread via GitHub
lucasbru merged PR #15688: URL: https://github.com/apache/kafka/pull/15688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-09 Thread via GitHub
philipnee opened a new pull request, #15688: URL: https://github.com/apache/kafka/pull/15688 beginningOrEndOffset and offsetforTimes should send a ListOffsetEvent and return empty results if the provided timeout is zero. A minor change to the mock timer with zero timeout in