Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1567506931 ## group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json: ## @@ -35,6 +35,20 @@ { "name": "RebalanceTimeoutMs", "type":

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1567506439 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -998,4 +1088,133 @@ public

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1567372730 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -998,4 +1088,133 @@ public

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1566918622 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +778,72 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1566001316 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -1046,4 +1051,101 @@ public void

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1565866968 ## group-coordinator/src/main/resources/common/message/ConsumerGroupMemberMetadataValue.json: ## @@ -35,6 +35,20 @@ { "name": "RebalanceTimeoutMs", "type": "int32",

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1560320708 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -180,12 +192,19 @@ public static class DeadlineAndEpoch {

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1560320708 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -180,12 +192,19 @@ public static class DeadlineAndEpoch {

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1560315985 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -761,6 +776,58 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1559052702 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -761,6 +776,58 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1555022535 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1300,6 +1341,68 @@ public Map groupAssignment() {

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1555022109 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1300,6 +1341,68 @@ public Map groupAssignment() {

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1555021412 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1244,6 +1267,24 @@ public boolean completeSyncFuture(

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1553514811 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -761,6 +777,31 @@ public ClassicGroup classicGroup( }

[PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 opened a new pull request, #15662: URL: https://github.com/apache/kafka/pull/15662 Based on https://github.com/apache/kafka/pull/15411, the pr contains triggering of group conversion from a classic group to a consumer group. In consumerGroupHeartbeat, the online migration

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

dongnuo123 commented on code in PR #15593: URL: https://github.com/apache/kafka/pull/15593#discussion_r1550242669 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/classic/ClassicGroup.java: ## @@ -1300,6 +1341,68 @@ public Map groupAssignment() {