Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-08 Thread via GitHub
showuon merged PR #15659: URL: https://github.com/apache/kafka/pull/15659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-08 Thread via GitHub
showuon commented on PR #15659: URL: https://github.com/apache/kafka/pull/15659#issuecomment-2043887866 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-08 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1556052135 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-08 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1555327569 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +301,15 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-06 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554537353 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-06 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554536274 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554519247 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -654,6 +654,13 @@ static Map> getReplicaAssignmentForPartitions(Admi

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws

[PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-04 Thread via GitHub
brandboat opened a new pull request, #15659: URL: https://github.com/apache/kafka/pull/15659 related to KAFKA-16455 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify