Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-12 Thread via GitHub
omkreddy merged PR #15658: URL: https://github.com/apache/kafka/pull/15658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-11 Thread via GitHub
VedarthConfluent commented on PR #15658: URL: https://github.com/apache/kafka/pull/15658#issuecomment-2050213120 Looks good to me! Thanks for the fix  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-04 Thread via GitHub
smarsching commented on code in PR #15658: URL: https://github.com/apache/kafka/pull/15658#discussion_r1552171112 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -87,8 +87,12 @@ object KafkaDockerWrapper { parser.parseArgsOrFail(args) } - private

Re: [PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-04 Thread via GitHub
brandboat commented on code in PR #15658: URL: https://github.com/apache/kafka/pull/15658#discussion_r1552104493 ## core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala: ## @@ -87,8 +87,12 @@ object KafkaDockerWrapper { parser.parseArgsOrFail(args) } - private

[PR] KAFKA-16473: Use correct cluster ID when formatting log dir. [kafka]

2024-04-04 Thread via GitHub
smarsching opened a new pull request, #15658: URL: https://github.com/apache/kafka/pull/15658 This fixes an issue that when starting a Docker container for the first time, the cluster ID used when formatting the log dir would not be `$CLUSTER_ID` but `Some($CLUSTER_ID)` (KAFKA-16473).