junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2123590782
@clolov : 3.8.0 feature freeze is about 1 week away. It would be useful to
get this PR in before the 3.8 branch is cut. Any updates on this PR? What's an
example of the failed test?
--
junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2104991266
@clolov @nikramakrishnan : If an RPC is only used by the client, we don't
need to bump up the IBP. However, ListOffsetRequest is used by both the client
and the broker. If we don't bump
nikramakrishnan commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2104320732
Given that we are marking the latest version as unstable in
ListOffsetsResponse, it would make sense to not bump the IBP now as @clolov
suggests, and only bump it when
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2104306940
Heya @junrao after inspecting some of the tests I think I have misunderstood
how marking an API version as unstable works. From a discussion with Nikhil I
think we can only do one of two
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2100946258
I will look at `kafka.server.ApiVersionsRequestTest` failures tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1593670905
##
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##
@@ -717,7 +717,7 @@ public void testUnregisterBroker() throws Throwable {
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1593668135
##
metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java:
##
@@ -283,7 +283,7 @@ private static Stream
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1592890872
##
metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java:
##
@@ -283,7 +283,7 @@ private static Stream
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2097975706
Heya @junrao! Let me know your thoughts on my responses. I have futher
updated the below + rebased. I am waiting on the tests to finish running and if
they uncover something I will aim to
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1592116050
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -70,7 +70,7 @@ else if (isolationLevel == IsolationLevel.READ_COMMITTED)
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1592114443
##
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##
@@ -219,7 +219,7 @@ class ListOffsetsRequestTest extends BaseRequestTest {
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2090629047
Heya, apologies, I will get to addressing these this weekend!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2089169862
@clolov: Are you able to address the remaining comments? 3.8.0 code freeze
is getting close. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1569221453
##
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##
@@ -70,7 +70,7 @@ else if (isolationLevel == IsolationLevel.READ_COMMITTED)
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2045111918
Hello @junrao! Yes, I had missed updating some of the tests - I believe the
majority of them should now be fixed, but I will circle back once the latest
build passes to check again
--
junrao commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2043718730
@clolov : Thanks for the PR. When we last bumped up metadata.version
(https://github.com/apache/kafka/pull/14984), we changed a bunch of tests such
as MetadataVersionTest,
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2042214344
Yup, I need to change the kafka-get-offsets tool to easily access said
functionality, but I am in the process of raising that PR
--
This is an automated message from the Apache Git
clolov opened a new pull request, #15673:
URL: https://github.com/apache/kafka/pull/15673
### Summary
This is a follow-up of https://github.com/apache/kafka/pull/15213 where I
missed updating the API version and the IBP version. I chose to mark the latest
version of the ListOffsets
18 matches
Mail list logo
