Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-11 Thread via GitHub
chia7712 merged PR #15676: URL: https://github.com/apache/kafka/pull/15676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-10 Thread via GitHub
KevinZTW commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1560373161 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,32 +19,31 @@ package kafka.coordinator.transaction

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1559385018 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,32 +19,31 @@ package kafka.coordinator.transaction

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
KevinZTW commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1558864630 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1558858994 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15676: URL: https://github.com/apache/kafka/pull/15676#issuecomment-2046467883 @KevinZTW Could you try to use the new function to update this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on PR #15676: URL: https://github.com/apache/kafka/pull/15676#issuecomment-2045116605 @KevinZTW Could you take a look at #15687? It offers a graceful way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-09 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1557539944 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,30 +19,30 @@ package kafka.coordinator.transaction

[PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-07 Thread via GitHub
KevinZTW opened a new pull request, #15676: URL: https://github.com/apache/kafka/pull/15676 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary