chia7712 merged PR #15679:
URL: https://github.com/apache/kafka/pull/15679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1577056133
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576508031
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,109 +58,141 @@
import static
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576432135
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576386813
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +256,7 @@ private KafkaProducer
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072421039
> @FrankYang0529 thanks for updated PR. please take a look at two comments.
Hi @chia7712, thanks for the review. Updated it.
--
This is an automated message from the Apache
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576262016
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -170,30 +227,23 @@ private void
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072251579
> > I think we can add new test case in next PR. We can more focus on
migrate to ClusterTestExtensions in this PR.
>
> Please take a look at [#15766
chia7712 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072132702
> I think we can add new test case in next PR. We can more focus on migrate
to ClusterTestExtensions in this PR.
Please take a look at
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2072051627
> @FrankYang0529 sorry that I check the PR again, and more comments are
left. PTAL
Hi @chia7712, I addressed last comments. I think we can add new test case in
next PR. We
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576082586
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -202,7 +238,7 @@ private KafkaProducer
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1576013151
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -171,29 +209,27 @@ private void
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2069788585
> @FrankYang0529 thanks for updated PR. two minor comments left. PTAL
Hi @chia7712, I addressed last comments. Thanks for the review.
--
This is an automated message from
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1574810225
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,75 +53,98 @@
import static
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1574007862
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -173,7 +208,11 @@ private void
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573834240
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -173,7 +208,11 @@ private void
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573832025
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573795818
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573623165
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1572912365
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
chia7712 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2065947030
> Do you think that we should revert unstable.api.versions.enable change and
try again? Thanks.
Yep
--
This is an automated message from the Apache Git Service.
To respond to
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2065616140
> > @FrankYang0529 Could you reduce the partition number of offsets topic?
It seems the timeout is caused by that coordinator is waiting for the offset
partition, and our CI could
FrankYang0529 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2064035886
> @FrankYang0529 Could you reduce the partition number of offsets topic? It
seems the timeout is caused by that coordinator is waiting for the offset
partition, and our CI could be
chia7712 commented on PR #15679:
URL: https://github.com/apache/kafka/pull/15679#issuecomment-2061751961
@FrankYang0529 Could you reduce the partition number of offsets topic? It
seems the timeout is caused by that coordinator is waiting for the offset
partition, and our CI could be too
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1557557116
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -213,4 +234,8 @@ private Consumer
FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1557490373
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,19 +48,40 @@
import static
chia7712 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1556382498
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -42,19 +48,40 @@
import static
FrankYang0529 opened a new pull request, #15679:
URL: https://github.com/apache/kafka/pull/15679
By using ClusterTestExtensions,
`DeleteOffsetsConsumerGroupCommandIntegrationTest` get away from
`KafkaServerTestHarness` dependency.
### Committer Checklist (excluded from commit
28 matches
Mail list logo
