Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-05-24 Thread via GitHub
mjsax commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1614074992 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -17,21 +17,73 @@ package org.apache.kafka.common.errors; import

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-05-24 Thread via GitHub
mjsax commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1614074321 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-05-24 Thread via GitHub
mjsax commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1614060982 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -17,21 +17,73 @@ package org.apache.kafka.common.errors; import

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-05-22 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1609600830 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -311,25 +311,35 @@ ConsumerRecord parseRecord(Deserializers

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-05-03 Thread via GitHub
fvaleri commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1589379241 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -311,25 +311,35 @@ ConsumerRecord parseRecord(Deserializers

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-19 Thread via GitHub
AndrewJSchofield commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1572845716 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -311,25 +312,33 @@ ConsumerRecord parseRecord(Deserializers

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561429541 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561426507 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-11 Thread via GitHub
fred-ro commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1561425249 ## clients/src/main/java/org/apache/kafka/common/errors/RecordDeserializationException.java: ## @@ -16,29 +16,38 @@ */ package org.apache.kafka.common.errors;

Re: [PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-10 Thread via GitHub
kirktrue commented on code in PR #15691: URL: https://github.com/apache/kafka/pull/15691#discussion_r1560342179 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CompletedFetch.java: ## @@ -326,7 +327,17 @@ ConsumerRecord parseRecord(Deserializers

[PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-10 Thread via GitHub
fred-ro opened a new pull request, #15691: URL: https://github.com/apache/kafka/pull/15691 Add raw ConsumerRecord data to RecordDeserialisationException to make DLQ implementation easier *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or