Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-05-13 Thread via GitHub
ableegoldman closed pull request #15819: KAFKA-16514: backdoor for modifying internal leave.group.on.close config URL: https://github.com/apache/kafka/pull/15819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-05-13 Thread via GitHub
ableegoldman commented on PR #15819: URL: https://github.com/apache/kafka/pull/15819#issuecomment-2109312290 Will do this via a KIP since there's some agreement that it makes sense for this to be configurable for plain consumer apps as well as Streams -- This is an automated message from

Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15819: URL: https://github.com/apache/kafka/pull/15819#discussion_r1584226418 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1469,6 +1469,10 @@ private Thread shutdownHelper(final boolean error, final long

Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-04-26 Thread via GitHub
ableegoldman commented on code in PR #15819: URL: https://github.com/apache/kafka/pull/15819#discussion_r1581729152 ## clients/src/main/java/org/apache/kafka/clients/GroupRebalanceConfig.java: ## @@ -83,6 +84,14 @@ public GroupRebalanceConfig(AbstractConfig config,

Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-04-26 Thread via GitHub
mjsax commented on code in PR #15819: URL: https://github.com/apache/kafka/pull/15819#discussion_r1581626291 ## clients/src/main/java/org/apache/kafka/clients/GroupRebalanceConfig.java: ## @@ -83,6 +84,14 @@ public GroupRebalanceConfig(AbstractConfig config, ProtocolType