Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-24 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1577407602 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java: ## @@ -198,6 +207,43 @@ private static void assertApiMessageAndVersionEquals(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-23 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1576113492 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1422,10 +1499,16 @@ private CoordinatorResult consumerGr )

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-22 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1574897141 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -10331,6 +10333,461 @@ public void

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-18 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1571520271 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java: ## @@ -198,6 +204,62 @@ private static void assertApiMessageAndVersionEquals(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-18 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1571469219 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -777,11 +778,78 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-18 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1571079283 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -777,11 +778,78 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569413973 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -777,6 +778,59 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569405350 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569077848 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -777,6 +778,59 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569055496 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -998,4 +1094,232 @@ public

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1569051446 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup( }

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568994033 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -998,4 +1094,232 @@ public

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568994033 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -998,4 +1094,232 @@ public

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568962281 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568963034 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dongnuo123 commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568962281 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup(

Re: [PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-17 Thread via GitHub
dajac commented on code in PR #15721: URL: https://github.com/apache/kafka/pull/15721#discussion_r1568737120 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -775,6 +777,126 @@ public ClassicGroup classicGroup( }

[PR] KAFKA-16554: Online downgrade triggering and group type conversion [kafka]

2024-04-15 Thread via GitHub
dongnuo123 opened a new pull request, #15721: URL: https://github.com/apache/kafka/pull/15721 Online downgrade from a consumer group to a classic group is triggered when the last consumer that uses the consumer protocol leaves the group. A rebalance is manually triggered after the group