Re: [PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-04-26 Thread via GitHub
chia7712 commented on PR #15815: URL: https://github.com/apache/kafka/pull/15815#issuecomment-2079444105 We are doing the migration so can this PR get pending before we see more use cases? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] KAFKA-16589: Consider removing `ClusterInstance#createAdminClient` since callers are not sure whether they need to call close [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 opened a new pull request, #15815: URL: https://github.com/apache/kafka/pull/15815 Sometimes we close the admin created by `createAdminClient`, and sometimes we don't. That is not a true problem since the `ClusterInstance` will call `close` when stopping. However, that