Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

chia7712 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2074861414 I don't see any related failure, so I'm going to merge it to trunk and branch 3.7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2073698582 The build got aborted again 樂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2072021300 @chia7712 , I created this ticket: [KAFKA-16604](https://issues.apache.org/jira/browse/KAFKA-16604) for tracking the KIP -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

chia7712 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2071864618 retrigger QA due to incomplete build. I will merge it after QA get completed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2070321267 Thanks @chia7712 , for now I have made the constructor added as part of https://github.com/apache/kafka/pull/13909 as private. Regarding > I guess we need a KIP to

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on code in PR #15762: URL: https://github.com/apache/kafka/pull/15762#discussion_r1575112513 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1256,6 +1256,16 @@ public static class ConfigKey { public final boolean

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

chia7712 commented on code in PR #15762: URL: https://github.com/apache/kafka/pull/15762#discussion_r1573826054 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1256,6 +1256,16 @@ public static class ConfigKey { public final boolean

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2068083995 Thanks @chia7712 , I am thinking we can make the constructors as private and let the users use only `define` method. Even in the AK codebase, I don't see the constructor being used

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

vamossagar12 commented on code in PR #15762: URL: https://github.com/apache/kafka/pull/15762#discussion_r1573818929 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1256,6 +1256,15 @@ public static class ConfigKey { public final boolean

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

chia7712 commented on code in PR #15762: URL: https://github.com/apache/kafka/pull/15762#discussion_r1573448544 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1256,6 +1256,15 @@ public static class ConfigKey { public final boolean

Re: [PR] KAFKA-16592: Add a new constructor which invokes the existing constructor with default value for alternativeString [kafka]

frankvicky commented on PR #15762: URL: https://github.com/apache/kafka/pull/15762#issuecomment-2067692915 @chia7712 Could you please assist me with reviewing this pull request ?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to