chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2127033316
It seems there are something is failed. Let's wait for
https://issues.apache.org/jira/browse/KAFKA-16828
--
This is an automated message from the Apache Git Service.
To respond to the
m1a2st commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1610809626
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +86,756 @@
* - scope=topics+partitions,
chia7712 commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1609776281
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +86,756 @@
* - scope=topics+partitions,
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2120776989
@chia7712, Please review, Thanks for your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1606053454
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +86,764 @@
* - scope=topics+partitions,
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2114598318
@chia7712, Thanks for your conversations, I already rebase this code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2113049965
@m1a2st could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2112434755
@chia7712 , Thanks for your review, these test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2110457406
```
Build / JDK 17 and Scala 2.13 / testResetOffsetsAllTopicsAllGroups [4]
Type=Raft-Combined, Name=consumerGroupCoordinator, MetadataVersion=3.8-IV0,
Security=PLAINTEXT –
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2108026784
@chia7712, Thanks for your review, I have been changed according to your
conversations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
m1a2st commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1597629743
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +91,787 @@
* - scope=topics+partitions,
FrankYang0529 commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1597626926
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +91,787 @@
* - scope=topics+partitions,
m1a2st commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +91,787 @@
* - scope=topics+partitions,
m1a2st commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +91,787 @@
* - scope=topics+partitions,
m1a2st commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1597596564
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -62,506 +91,787 @@
* - scope=topics+partitions,
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2106119689
@chia7712 , Thanks for your review, I have been modify all test for testing
different groupProtocol type. Please review again
--
This is an automated message from the Apache Git
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2105943653
@m1a2st Could you please make sure "all" available consumer groups are
included in this test? For example: `produceConsumeAndShutdown` creates
consumer only for `classic`.
--
chia7712 commented on code in PR #15779:
URL: https://github.com/apache/kafka/pull/15779#discussion_r1596279690
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java:
##
@@ -415,153 +474,246 @@ public void
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2099697982
@m1a2st Could you please use `ConsumerGroupCommandTestUtils#generator` to
rewrite this test? thanks!
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2098864822
@chia7712 , please take a look for this PR, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2083099739
Rely on #15766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2073680590
@lianetm @chia7712 Thanks for your comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070801312
@m1a2st Please add following server property:
```java
@ClusterTestDefaults(clusterType = Type.ALL, serverProperties = {
@ClusterConfigProperty(key =
lianetm commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070678792
Hey @m1a2st , the way to get the servers' addresses is
`cluster.bootstrapServers()`, you got it right, but I see you're not inheriting
from `ConsumerGroupCommandTest` anymore, so that
m1a2st commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2069841257
@chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
m1a2st opened a new pull request, #15779:
URL: https://github.com/apache/kafka/pull/15779
change the ResetConsumerGroupOffsetTest first to new test framework
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
26 matches
Mail list logo
