chia7712 merged PR #15803:
URL: https://github.com/apache/kafka/pull/15803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15803:
URL: https://github.com/apache/kafka/pull/15803#issuecomment-2093997309
@lianetm any feedbacks? I'd like to merge it later :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
AndrewJSchofield commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1587067096
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -173,15 +173,23 @@ void awaitNotEmpty(Timer timer) {
chia7712 commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1586968300
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -173,15 +173,23 @@ void awaitNotEmpty(Timer timer) {
//
AndrewJSchofield commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1585852808
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
lianetm commented on PR #15803:
URL: https://github.com/apache/kafka/pull/15803#issuecomment-2083525470
Thanks for the catch and the fix @AndrewJSchofield, left a nit, but LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lianetm commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1583641482
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
AndrewJSchofield commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1580787182
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
chia7712 commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1580186766
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
AndrewJSchofield opened a new pull request, #15803:
URL: https://github.com/apache/kafka/pull/15803
The contract of KafkaConsumer.poll(Duration) says that it throws
InterruptException "if the calling thread is interrupted before or while this
function is called". The new KafkaConsumer
10 matches
Mail list logo
