gharris1727 merged PR #15597:
URL: https://github.com/apache/kafka/pull/15597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #15597:
URL: https://github.com/apache/kafka/pull/15597#issuecomment-2026050399
Test failures appear unrelated:
1. ReplicaManagerTest has tickets
[KAFKA-16323](https://issues.apache.org/jira/browse/KAFKA-16323) and
mimaison commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1543174303
##
core/src/main/scala/kafka/controller/PartitionStateMachine.scala:
##
@@ -486,7 +486,7 @@ class ZkPartitionStateMachine(config: KafkaConfig,
} else {
gharris1727 commented on PR #15597:
URL: https://github.com/apache/kafka/pull/15597#issuecomment-2023838245
Hi @mimaison @C0urante PTAL at the latest WorkerConfig change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541420383
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -580,8 +601,15 @@ private Map
instantiateConfigProviders(Map
OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541328444
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -925,10 +926,13 @@ static Map adminConfigs(String connName,
// Ignore
OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541293009
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -580,8 +601,15 @@ private Map
instantiateConfigProviders(Map providerClassName =
OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541313630
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1502,13 +1502,23 @@ public static Map filterMap(final Map map, final Predicate
mjsax commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541286490
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -58,6 +61,8 @@ public class AbstractConfig {
private final ConfigDef
C0urante commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540232126
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -547,6 +552,17 @@ private Map
extractPotentialVariables(Map configMap) {
gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540169589
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -547,6 +552,17 @@ private Map
extractPotentialVariables(Map configMap) {
gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540167974
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -547,6 +552,17 @@ private Map
extractPotentialVariables(Map configMap) {
C0urante commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540093517
##
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##
@@ -461,6 +497,25 @@ public void
gharris1727 commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1540111732
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -58,6 +61,8 @@ public class AbstractConfig {
private final ConfigDef
mimaison commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1539776305
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -58,6 +61,8 @@ public class AbstractConfig {
private final ConfigDef
gharris1727 opened a new pull request, #15597:
URL: https://github.com/apache/kafka/pull/15597
Add Utils.castToStringObjectMap and fix unchecked casts in AbstractConfig
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
16 matches
Mail list logo
