chia7712 commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-2071780823
I have backport this PR to 3.7 see
https://github.com/apache/kafka/commit/6e998cffdd33e343945877ccee1fec8337c7d57d
--
This is an automated message from the Apache Git Service.
To
chia7712 commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-2069776278
When testing 3.7 branch for #15776, I encountered following error:
```
java.util.concurrent.ExecutionException:
org.apache.kafka.common.errors.InvalidTopicException: Topic
cadonna merged PR #14983:
URL: https://github.com/apache/kafka/pull/14983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-1853482186
The failed Streams tests are either known to be flaky (I checked the failure
reason) or I ran into a timeout. For the ones that run into a timeout I checked
if they run locally w/o
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1424055596
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
The goal is to migrate them to JUnit 5 but sadly there is no execution plan.
--
dajac commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1424053661
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
Would you know if there is an equivalent config for JUnit4? Or, do we have a
plan to
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1424005229
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
Yes, their display name does not change compared to before this PR.
--
This is an
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1424005229
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
Yes, their display name does not change.
--
This is an automated message from the
dajac commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423998585
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
I see. Do we also have parameterized tests using JUnit4?
--
This is an automated
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423995936
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
There is not a change with JUnit4 tests.
--
This is an automated message from the
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423993764
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
Apparently, it gets both. I see:
```
Dec 12, 2023 2:22:50 PM
dajac commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423948035
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
I am not sure. I thought that Streams would get it from the clients package.
We could
cadonna commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423945890
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
@dajac Do you know whether we need this file also in the streams package? In
the
lucasbru commented on code in PR #14983:
URL: https://github.com/apache/kafka/pull/14983#discussion_r1423829493
##
clients/src/test/resources/junit-platform.properties:
##
Review Comment:
Can you check if we need this file as well in the streams package?
--
This is an
cadonna commented on PR #14983:
URL: https://github.com/apache/kafka/pull/14983#issuecomment-1850549930
There was not a single streams failure in the builds:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-14983/1/#showFailuresLink
--
This is an automated message from the
cadonna opened a new pull request, #14983:
URL: https://github.com/apache/kafka/pull/14983
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
dajac merged PR #14687:
URL: https://github.com/apache/kafka/pull/14687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415612525
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
cadonna commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415253303
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1415122463
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
cadonna commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1412039372
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,14 @@ public static String safeUniqueTestName(final
dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1834494230
I cannot get a clean build for this one...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1410811193
##
streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java:
##
@@ -137,8 +138,8 @@ private void
cadonna commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1410730716
##
streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java:
##
@@ -137,8 +138,8 @@ private void
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1408976485
##
streams/src/test/java/org/apache/kafka/streams/integration/HighAvailabilityTaskAssignorIntegrationTest.java:
##
@@ -138,7 +138,7 @@ private void
dajac commented on code in PR #14687:
URL: https://github.com/apache/kafka/pull/14687#discussion_r1408975349
##
streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java:
##
@@ -239,10 +240,8 @@ public static String safeUniqueTestName(final
dajac commented on PR #14687:
URL: https://github.com/apache/kafka/pull/14687#issuecomment-1830424668
We need to investigate the failed tests before we can merge this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
27 matches
Mail list logo
