dajac merged PR #15818:
URL: https://github.com/apache/kafka/pull/15818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583572562
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1560,13 +1561,15 @@ private List
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583571521
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583565827
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
private
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583442656
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1560,13 +1561,15 @@ private List
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583441095
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1499,33 +1499,28 @@ private
CoordinatorResult consumerGr
)
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583297740
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583293395
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1524,7 +1524,8 @@ private
CoordinatorResult consumerGr
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583236338
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
private
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583231794
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -44,8 +44,8 @@ public class CoordinatorResult {
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583163477
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1524,7 +1524,8 @@ private
CoordinatorResult consumerGr
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153537
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2718,7 +2719,7 @@ private CoordinatorResult
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153282
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3381,7 +3382,7 @@ private CoordinatorResult
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583153766
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -2300,7 +2301,7 @@ public CoordinatorResult classicGroupJoin(
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583152680
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3497,7 +3498,7 @@ public CoordinatorResult classicGroupSync(
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583152183
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3772,7 +3773,8 @@ public CoordinatorResult
classicGroupLeave(
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583125181
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List
dongnuo123 commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1583125181
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List
dajac commented on code in PR #15818:
URL: https://github.com/apache/kafka/pull/15818#discussion_r1582660947
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorResult.java:
##
@@ -80,10 +86,28 @@ public CoordinatorResult(
List
dongnuo123 commented on PR #15818:
URL: https://github.com/apache/kafka/pull/15818#issuecomment-2081675669
> @dongnuo123 Thanks for the patch. Could you also check if we have other
cases like this one:
>
>
dajac commented on PR #15818:
URL: https://github.com/apache/kafka/pull/15818#issuecomment-2080046398
@dongnuo123 Thanks for the patch. Could you also check if we have other
cases like this one:
dongnuo123 opened a new pull request, #15818:
URL: https://github.com/apache/kafka/pull/15818
The patch adds a boolean attribute `replayRecords` that specifies whether
the records should be replayed. The default value is `appendFuture == null` so
no change is needed for the existing code.
22 matches
Mail list logo
