github-actions[bot] commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-2048870549
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1886801135
@mumrah it also crossed my mind when implementing this, however it seemed to
have a little bit high entry levels (publishing, etc.) compared to this little
bash script. It would
mumrah commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1883771689
> Although that way we won't be able to merge it via browser
That's a non-starter IMO.
I wonder if we could write our own bot for these kinds of automations.
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1883367313
@mimaison I'll ask infra. It seems like though that we may not be able to
give a workaround to this problem as GH seems to prevent write permissions for
resources that are coming
mimaison commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1880112013
No, I don't have admin rights on the repo, you need to ask infra.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mumrah commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1879742321
> Do you think we can change this? We'll probably need an admin for the
repo, I'm just a simple member and can't do anything basically. I'll try to
work this out in my own repo (will ask
mumrah commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1442270635
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1877217071
@mumrah @divijvaidya, the script just edits the PR body, it won't touch the
commit itself.
I discovered yesterday that this PR also already runs the action, however it
viktorsomogyi commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1441813320
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
viktorsomogyi commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1441800052
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
divijvaidya commented on code in PR #15115:
URL: https://github.com/apache/kafka/pull/15115#discussion_r1440702318
##
.github/workflows/pr_reviews.yml:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.
mumrah commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875698491
Thanks @viktorsomogyi, this is a nice little automation.
Does this script edit the commit or just the PR body?
--
This is an automated message from the Apache Git Service.
To
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875609641
One more thing is that the current script places the "Reviewers:" section
after "Committer checklist" so it's not automatically included in the merge
template. I'll see if that can
viktorsomogyi commented on PR #15115:
URL: https://github.com/apache/kafka/pull/15115#issuecomment-1875576165
One caveat with the "Name \" format is that \<\> is markup
syntax and means superscript. This doesn't work however in case of emails, so
Github will just display "Name name@email",
viktorsomogyi opened a new pull request, #15115:
URL: https://github.com/apache/kafka/pull/15115
This PR adds a github action that is triggered when a GitHub review is
submitted.
The action does the following:
- if there is no "Reviewers" line at the end of the description, then
15 matches
Mail list logo
