Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

chia7712 merged PR #15714: URL: https://github.com/apache/kafka/pull/15714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1576372796 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

chia7712 commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1570903125 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1568968759 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

chia7712 commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1567861049 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566619569 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566612658 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566612024 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566609363 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1566606914 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

chia7712 commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1565426868 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on PR #15714: URL: https://github.com/apache/kafka/pull/15714#issuecomment-2053970919 >@KevinZTW thanks for enhancing the test coverage. Could you also add unit tests for other methods? thanks @chia7712 no problem! I have added test cases to cover other methods,

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564569432 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564564066 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

brandboat commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564160360 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

Re: [PR] MINOR: Add test for PartitionMetadataFile [kafka]

chia7712 commented on code in PR #15714: URL: https://github.com/apache/kafka/pull/15714#discussion_r1564094159 ## storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[PR] MINOR: Add test for PartitionMetadataFile [kafka]

KevinZTW opened a new pull request, #15714: URL: https://github.com/apache/kafka/pull/15714 In PartitionMetadataFile.java, there is a defensive early-fail design when setting a different topicId, but there are no corresponding test cases. Hence, this PR adds two tests for setting the same