jolshan commented on PR #15454:
URL: https://github.com/apache/kafka/pull/15454#issuecomment-1998091660
Hmm. I was rerunning just to confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison merged PR #15454:
URL: https://github.com/apache/kafka/pull/15454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15454:
URL: https://github.com/apache/kafka/pull/15454#issuecomment-1998016477
Test failures don't seem related (all passed locally), merging to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jolshan commented on PR #15454:
URL: https://github.com/apache/kafka/pull/15454#issuecomment-1986575283
Can you check `testTransactionCoordinatorResolution()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jolshan commented on code in PR #15454:
URL: https://github.com/apache/kafka/pull/15454#discussion_r1518416635
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -98,19 +99,20 @@ class AddPartitionsToTxnManagerTest {
splett2 commented on code in PR #15454:
URL: https://github.com/apache/kafka/pull/15454#discussion_r1511954682
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -80,10 +81,9 @@ class AddPartitionsToTxnManager(
topicPartitions: Seq[TopicPartition],
splett2 opened a new pull request, #15454:
URL: https://github.com/apache/kafka/pull/15454
A few minor optimizations:
1. Cache the interbroker listener name instead of computing it each time.
The value of the interbroker listener name cannot change without a process
restart.
2. we're
