Re: [PR] MINOR: Change config. compressionType to be an enum type instead [kafka]

2024-03-08 Thread via GitHub
divijvaidya commented on PR #15403: URL: https://github.com/apache/kafka/pull/15403#issuecomment-1986041001 Hey @testn Tests in the CI seem to be failing due to this change such as

Re: [PR] MINOR: Change config. compressionType to be an enum type instead [kafka]

2024-02-23 Thread via GitHub
divijvaidya commented on PR #15403: URL: https://github.com/apache/kafka/pull/15403#issuecomment-1961076220 The build is failing because we need to modify a few other tests to use enum instead of string. Please tag me here again for review once we have a green build. -- This is an

[PR] MINOR: Change config. compressionType to be an enum type instead [kafka]

2024-02-21 Thread via GitHub
testn opened a new pull request, #15403: URL: https://github.com/apache/kafka/pull/15403 Currently, `LogConfig.compressionType` is a string so `UnifiedLog.append` has to convert string into enum all the time which seems to waste a lot of CPU time for something that is rarely changed.