chia7712 merged PR #15808:
URL: https://github.com/apache/kafka/pull/15808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584251393
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584248006
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584212773
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584199554
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -1086,4 +1087,10 @@ class RemoteIndexCacheTest {
case e @ (_ : NoSuchFileException
chia7712 commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2084476066
@m1a2st please make sure the build gets work with scala 2.12. You can use
following command: `./gradlew clean build -x test -PscalaVersion=2.12`
--
This is an automated message from
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584095279
##
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##
@@ -1086,4 +1087,10 @@ class RemoteIndexCacheTest {
case e @ (_ :
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582841761
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs =
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582842857
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs =
m1a2st commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582841761
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs =
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1582280178
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1124,24 +933,18 @@ object TestUtils extends Logging {
}, msg = msg, pause = 0L, waitTimeMs =
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2081287054
I have been remove these unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2081116425
```
[2024-04-27T01:29:26.736Z] > Task :core:compileTestScala
[2024-04-27T01:29:26.736Z] [Error]
chia7712 commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2080226483
@m1a2st Could you please fix conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078587040
@chia7712 thanls for your comment, I have already change these code by your
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1580291046
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -1594,10 +1313,6 @@ object TestUtils extends Logging {
}
}
- def createIsrChangeListener():
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078376955
@chia7712 I resolve the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2078361586
@m1a2st Could you please fix the conflicts? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
m1a2st commented on PR #15808:
URL: https://github.com/apache/kafka/pull/15808#issuecomment-2077728033
@chia7712 please review this PR, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
m1a2st opened a new pull request, #15808:
URL: https://github.com/apache/kafka/pull/15808
Because TestUtils.scala has some unused method, and some methods only use in
one class, so I delete unused methods and move methods to individual class
which only one class used
--
This is an
20 matches
Mail list logo
