Re: [PR] MINOR: Extracted the creation of ReplicaManager in BrokerServer [kafka]

2024-04-01 Thread via GitHub
FilipePintoReis commented on PR #15617: URL: https://github.com/apache/kafka/pull/15617#issuecomment-2030926033 Thanks for the prompt reply @soarez ! I'm playing around with these servers and extending their behaviour, I don't think these tests will be useful for open source.

Re: [PR] MINOR: Extracted the creation of ReplicaManager in BrokerServer [kafka]

2024-03-28 Thread via GitHub
soarez commented on PR #15617: URL: https://github.com/apache/kafka/pull/15617#issuecomment-2026228502 Olá Filipe. Thanks for your contribution. `BrokerServer` shouldn't aim to follow the structure or interface in `KafkaServer`. What those two are meant to have in common is defined