Re: [PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
alok123t commented on PR #15707: URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052600875 @jolshan @chia7712 randomly looking at the code base, i think this is prevalent in multiple places. Shall I update them all in this PR and also create a ticket? -- This is an

Re: [PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on PR #15707: URL: https://github.com/apache/kafka/pull/15707#issuecomment-2052183089 the following links have similar issue. Should we fix them in this PR or I file a follow-up to fix them?

[PR] MINOR: Fix incorrect equals comparison of topicId by reference in PartitionMetadataFile [kafka]

2024-04-12 Thread via GitHub
alok123t opened a new pull request, #15707: URL: https://github.com/apache/kafka/pull/15707 Previously, we were comparing uuid by reference, which could be incorrect. This PR replaces to do the comparison by value instead ### Committer Checklist (excluded from commit message) - [