showuon merged PR #15522:
URL: https://github.com/apache/kafka/pull/15522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2051055209
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2049237739
@soarez , there is failed test... :(
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2047096126
@soarez , oops, there's conflict due to I've just merged another PR. Please
help resolve it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2047072476
Sorry, forgot about this PR. The jdk8 job failed to complete due to infra's
issue. Re-triggering now:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15522/6/
--
This is an
soarez commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2046961029
Failing tests are all unrelated and tracked:
*
kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest."testNoConsumeWithDescribeAclViaAssign(String).quorum=kraft"
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2033354648
```
/home/jenkins/workspace/Kafka_kafka-pr_PR-15522/server/src/test/java/org/apache/kafka/server/AssignmentsManagerTest.java:354:
error: method onAssignment in class
soarez commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1548655446
##
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##
@@ -458,7 +458,7 @@ class ReplicaAlterLogDirsThreadTest {
showuon commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1547005718
##
core/src/test/scala/unit/kafka/server/ReplicaAlterLogDirsThreadTest.scala:
##
@@ -458,7 +458,7 @@ class ReplicaAlterLogDirsThreadTest {
soarez commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1546358504
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -105,7 +105,7 @@ class ReplicaAlterLogDirsThread(name: String,
topicId <-
soarez commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1546352789
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -624,6 +624,13 @@ class ReplicaManager(val config: KafkaConfig,
errorMap
}
+ def
soarez commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1546351970
##
core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala:
##
@@ -105,7 +105,7 @@ class ReplicaAlterLogDirsThread(name: String,
topicId <-
showuon commented on code in PR #15522:
URL: https://github.com/apache/kafka/pull/15522#discussion_r1546066080
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -624,6 +624,13 @@ class ReplicaManager(val config: KafkaConfig,
errorMap
}
+ def
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2022115723
Will check it this week or next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
soarez commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-1991528082
@showuon PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
15 matches
Mail list logo
