chia7712 merged PR #15782:
URL: https://github.com/apache/kafka/pull/15782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076894379
> @TaiJuWu could you please rebase code to include #15801
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076761562
@TaiJuWu could you please rebase code to include
https://github.com/apache/kafka/pull/15801
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2074037067
@TaiJuWu Could you please rebase code to trigger QA again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2073234352
re-trigger QA since some builds get terminated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2072107254
> Thank you for the changes.
>
> Is there a reason to prefer the `java.lang.` prefix?
There is no special reason, Removing prefix is ok.
Following other code, Removing
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070867568
> @TaiJuWu thanks for your contribution. Could you fix
https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776
also?
Sure.
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070865680
@TaiJuWu thanks for your contribution. Could you fix
https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776
also?
--
This is an
TaiJuWu opened a new pull request, #15782:
URL: https://github.com/apache/kafka/pull/15782
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
