Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

ijuma commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1518649604 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -336,33 +337,35 @@ public long timeToNextUpdate(long

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

ijuma commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1518649290 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -336,33 +337,35 @@ public long timeToNextUpdate(long

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1986036580 @testn congratulations on your first contribution to Apache Kafka! Hopefully first of many more to come. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1986032863 The test failures are unrelated to this change. @testn You can see the test failures in the orange build by clicking on the arrow on top right. We have a flaky test suite but

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya merged PR #15402: URL: https://github.com/apache/kafka/pull/15402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1976121691 @divijvaidya seem like the build is orange! https://github.com/apache/kafka/assets/445123/552aca8e-a9c3-406c-9333-7d1e928190d3;> -- This is an automated message from the

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1959819714 The build is still failing though @testn please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1499533378 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

testn commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1499417536 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1499048813 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

testn commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1498498644 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1498116256 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1957192264 > Nice! Small but very helpful change. > > Out of curiosity, do you happen to have any ideas to detect such performance-inefficiencies automatically in future? Currently,

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1957177698 Add the file to the suppression list instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

divijvaidya commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1956592176 @testn could you please fix the checkstyle failures which is causing the build to fail.