ableegoldman commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1998996811
Well 1 of the 4 JDK builds was aborted for some unknown but the other 3
builds completed with only unrelated test failures.
Given this is literally only touching on javadocs
ableegoldman commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1993664255
My official take on this is: `Headers` is a stupid class. Why is it
mutable?? Seems very silly to me
Though I'm sure there is (or at least _was_) a reason...
Anyways,
ableegoldman commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1993658568
Ah, thanks for the reality check guys -- I always forget about `Headers`
being mutable
Glad John deprecated the method way back when since the deprecation warning
was how
mjsax commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1989699015
What Bruno says. Git history if you friend :)
https://github.com/apache/kafka/pull/6602/files#r278810522
I think we should keep the code as-is and close this PR w/o merging (or
cadonna commented on PR #15508:
URL: https://github.com/apache/kafka/pull/15508#issuecomment-1988235647
@ableegoldman I had a quick look at the code and theoretically
`ProcessorRecordContext` is mutable because `headers()` returns a reference to
the object of `Headers` stored internally.
ableegoldman opened a new pull request, #15508:
URL: https://github.com/apache/kafka/pull/15508
Something I noticed while working on a new feature -- this class has
deprecated its hashcode and actually goes so far as to throw an exception
if/when it's invoked. The deprecation note claims
