chia7712 merged PR #15788:
URL: https://github.com/apache/kafka/pull/15788
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2083898472
```
./gradlew cleanTest :streams:test --tests
SlidingWindowedKStreamIntegrationTest.shouldRestoreAfterJoinRestart :tools:test
--tests
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2082935001
@chia7712
just updated, thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
johnnychhsu commented on code in PR #15788:
URL: https://github.com/apache/kafka/pull/15788#discussion_r1583203145
##
core/src/main/scala/kafka/MetadataLogConfig.scala:
##
@@ -32,13 +32,13 @@ final case class MetadataLogConfig(
)
object MetadataLogConfig {
- def
chia7712 commented on code in PR #15788:
URL: https://github.com/apache/kafka/pull/15788#discussion_r1582265983
##
core/src/main/scala/kafka/MetadataLogConfig.scala:
##
@@ -32,13 +32,13 @@ final case class MetadataLogConfig(
)
object MetadataLogConfig {
- def apply(config:
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2081407268
thanks @chia7712!
just rebased and fixed the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2080225060
@johnnychhsu Could you please fix conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-208202
thanks for the prompt reply @OmniaGM !
just updated to resolve the conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
OmniaGM commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077482581
Just rebase to fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077461634
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
> The reason these aren't used is because `MetadataLogConfig` signature uses
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2075021540
thanks for the review and suggestions @chia7712 @OmniaGM
let me check and address it
--
This is an automated message from the Apache Git Service.
To respond to the message,
OmniaGM commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2074499876
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
>
>
chia7712 commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2072851173
@johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
johnnychhsu opened a new pull request, #15788:
URL: https://github.com/apache/kafka/pull/15788
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
14 matches
Mail list logo
