Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-16 Thread via GitHub
mimaison merged PR #15705: URL: https://github.com/apache/kafka/pull/15705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-16 Thread via GitHub
mimaison commented on PR #15705: URL: https://github.com/apache/kafka/pull/15705#issuecomment-2059036435 None of the test failures seem related, merging to trunk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565764251 ## clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorStrategy.java: ## @@ -136,8 +136,8 @@ private CoordinatorKey requireSingletonAndType(Set

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565721043 ## clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java: ## @@ -79,12 +79,8 @@ public ByteBuffer get(int size) { @Override public

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565719621 ## clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java: ## @@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1565718889 ## clients/src/main/java/org/apache/kafka/common/network/SslChannelBuilder.java: ## @@ -60,7 +58,6 @@ public SslChannelBuilder(Mode mode, this.mode = mode;

Re: [PR] MINOR: Various cleanups in clients [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15705: URL: https://github.com/apache/kafka/pull/15705#discussion_r1562938471 ## clients/src/main/java/org/apache/kafka/common/memory/GarbageCollectedMemoryPool.java: ## @@ -37,13 +37,13 @@ public class GarbageCollectedMemoryPool extends

[PR] MINOR: Various cleanups in clients [kafka]

2024-04-12 Thread via GitHub
mimaison opened a new pull request, #15705: URL: https://github.com/apache/kafka/pull/15705 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including