chia7712 merged PR #15806:
URL: https://github.com/apache/kafka/pull/15806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15806:
URL: https://github.com/apache/kafka/pull/15806#issuecomment-2078233197
```
./gradlew cleanTest :streams:test --tests
StreamsAssignmentScaleTest.testHighAvailabilityTaskAssignorManyStandbys
:tools:test --tests
mimaison opened a new pull request, #15806:
URL: https://github.com/apache/kafka/pull/15806
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
mimaison merged PR #14734:
URL: https://github.com/apache/kafka/pull/14734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1809735473
The rebuild has a different set of failures and
`:streams:upgrade-system-tests-23:test` was fine across all pipelines. I'll
merge this in trunk. Thanks for the review!
--
This is an
jlprat commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1808282654
@mimaison I also highly doubt this PR is the cause, but it would be good to
know if the test was just flaky or something went wrong in previous PRs
--
This is an automated message from
mimaison commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1808279317
The PR does not touch streams and it builds fine locally with Java 21 and
Scala 2.13. To be extra safe I kicked a rebuild:
jlprat commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1808233060
Navigating to
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14734/1/pipeline/
I see an error:
> FAILURE: Build failed with an exception.
>
mimaison commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1808226806
> LGTM then, as long as the system tests for 2.3 turns green somehow (or
it's accepted that is flaky)
What do you mean?
--
This is an automated message from the Apache Git
mimaison commented on code in PR #14734:
URL: https://github.com/apache/kafka/pull/14734#discussion_r1391134864
##
metadata/src/main/java/org/apache/kafka/metadata/placement/StripedReplicaPlacer.java:
##
@@ -33,89 +33,86 @@
/**
* The striped replica placer.
- *
- *
- *
mimaison commented on code in PR #14734:
URL: https://github.com/apache/kafka/pull/14734#discussion_r1391134127
##
metadata/src/main/java/org/apache/kafka/metadata/placement/StripedReplicaPlacer.java:
##
@@ -33,89 +33,86 @@
/**
* The striped replica placer.
- *
- *
- *
mimaison commented on PR #14734:
URL: https://github.com/apache/kafka/pull/14734#issuecomment-1808184173
Thanks @jlprat for taking a look. In most javadoc blocks we don't close
`` tags, so I did that to be consistent.
--
This is an automated message from the Apache Git Service.
To
jlprat commented on code in PR #14734:
URL: https://github.com/apache/kafka/pull/14734#discussion_r1390959569
##
metadata/src/main/java/org/apache/kafka/metadata/placement/StripedReplicaPlacer.java:
##
@@ -33,89 +33,86 @@
/**
* The striped replica placer.
- *
- *
- * GOALS
mimaison opened a new pull request, #14734:
URL: https://github.com/apache/kafka/pull/14734
- Remove unused code, suppression
- Simplify/fix test assertions
- Javadoc cleanups
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
-
14 matches
Mail list logo
