Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

2024-04-16 Thread via GitHub
chia7712 merged PR #15710: URL: https://github.com/apache/kafka/pull/15710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1565897312 ## server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java: ## @@ -116,8 +116,7 @@ public synchronized boolean

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

2024-04-15 Thread via GitHub
mimaison commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1565856071 ## server/src/main/java/org/apache/kafka/server/AssignmentsManager.java: ## @@ -321,7 +321,7 @@ public void run() throws Exception {

Re: [PR] MINOR: Various cleanups in server and server-common [kafka]

2024-04-12 Thread via GitHub
chia7712 commented on code in PR #15710: URL: https://github.com/apache/kafka/pull/15710#discussion_r1562828732 ## server-common/src/test/java/org/apache/kafka/timeline/SnapshotRegistryTest.java: ## @@ -41,9 +42,7 @@ public void testEmptyRegistry() { private static void