showuon merged PR #15610:
URL: https://github.com/apache/kafka/pull/15610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15610:
URL: https://github.com/apache/kafka/pull/15610#issuecomment-2031206526
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
showuon commented on PR #15610:
URL: https://github.com/apache/kafka/pull/15610#issuecomment-2029071458
@AndrewJSchofield , Do you have any other comments? I'm going to merge this
PR this week if no other comments. Thanks.
--
This is an automated message from the Apache Git Service.
To
KevinZTW commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542216359
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -806,12 +806,10 @@ private static void executeMoves(Admin adminClient,
showuon commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542188367
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -1485,6 +1483,7 @@ static Set
alterReplicaLogDirs(Admin adminClient,
AndrewJSchofield commented on code in PR #15610:
URL: https://github.com/apache/kafka/pull/15610#discussion_r1542090972
##
tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java:
##
@@ -806,12 +806,10 @@ private static void executeMoves(Admin
