Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
omkreddy commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069192637 Lets also cherry-pick to 3.7 and 3.6 branches -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069206424 Yea, just had the same thought, will do in a couple of minutes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi merged PR #15758: URL: https://github.com/apache/kafka/pull/15758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: example.com moved [kafka]

2024-04-22 Thread via GitHub
viktorsomogyi commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2069166189 Ok, a couple of tests failed but none of them is ClientUtilsTest, so I'm merging this. Thank you @akatona84 for your contribution, @brandboat and @chia7712 for the reviews. --

Re: [PR] MINOR: example.com moved [kafka]

2024-04-20 Thread via GitHub
brandboat commented on code in PR #15758: URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] MINOR: example.com moved [kafka]

2024-04-20 Thread via GitHub
brandboat commented on code in PR #15758: URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] MINOR: example.com moved [kafka]

2024-04-20 Thread via GitHub
brandboat commented on code in PR #15758: URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] MINOR: example.com moved [kafka]

2024-04-19 Thread via GitHub
akatona84 commented on code in PR #15758: URL: https://github.com/apache/kafka/pull/15758#discussion_r1572917082 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] MINOR: example.com moved [kafka]

2024-04-19 Thread via GitHub
chia7712 commented on code in PR #15758: URL: https://github.com/apache/kafka/pull/15758#discussion_r1572897153 ## clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java: ## @@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {

Re: [PR] MINOR: example.com moved [kafka]

2024-04-19 Thread via GitHub
akatona84 commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2066839773 ipv6 alternates between 2606:2800:21f:cb07:6820:80da:af6b:8b2c and the old one, it's hard to fix the test like this. -- This is an automated message from the Apache Git Service.

Re: [PR] MINOR: example.com moved [kafka]

2024-04-19 Thread via GitHub
akatona84 commented on PR #15758: URL: https://github.com/apache/kafka/pull/15758#issuecomment-2066418336 now the ipv6 address is changed to 2606:2800:220:1:248:1893:25c8:1946... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] MINOR: example.com moved [kafka]

2024-04-19 Thread via GitHub
akatona84 opened a new pull request, #15758: URL: https://github.com/apache/kafka/pull/15758 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade