chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1612965039
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -68,15 +68,31 @@ static List generator() {
FrankYang0529 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1601924534
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -93,6 +95,27 @@ static AutoCloseable buildConsumers(int
chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1600210615
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -93,6 +95,27 @@ static AutoCloseable buildConsumers(int
chia7712 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2107364174
@FrankYang0529 please rebase code to include
https://github.com/apache/kafka/commit/334d5d58bb73ca04d04be90dec8c4e49000577ec
--
This is an automated message from the Apache Git
FrankYang0529 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1597470470
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -92,6 +94,7 @@ static void generator(ClusterGenerator
chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1596196298
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##
@@ -92,6 +94,7 @@ static void generator(ClusterGenerator
FrankYang0529 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2102879454
> > This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I
think we can create a new class SimpleConsumerGroupExecutorTestUtils for it.
WDYT? Thank you.
>
>
chia7712 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2099700974
> This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I
think we can create a new class SimpleConsumerGroupExecutorTestUtils for it.
WDYT? Thank you.
That is
FrankYang0529 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2098714976
Hi @chia7712, I rebase latest trunk branch, so we have
`ConsumerGroupCommandTestUtils` now. The only remaining part is
`SimpleConsumerGroupExecutor`. This is used by
FrankYang0529 commented on PR #15821:
URL: https://github.com/apache/kafka/pull/15821#issuecomment-2080374723
Rely on https://github.com/apache/kafka/pull/15766.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FrankYang0529 opened a new pull request, #15821:
URL: https://github.com/apache/kafka/pull/15821
By using `ClusterTestExtensions`, `ListConsumerGroupTest` get get away from
`KafkaServerTestHarness` dependency.
### Committer Checklist (excluded from commit message)
- [ ] Verify
11 matches
Mail list logo
