Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-26 Thread via GitHub
chia7712 merged PR #15802: URL: https://github.com/apache/kafka/pull/15802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1580759879 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -169,20 +201,22 @@ private static

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-26 Thread via GitHub
FrankYang0529 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1580755873 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -91,65 +91,97 @@ public void

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1579708062 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -169,20 +201,22 @@ private static

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on code in PR #15802: URL: https://github.com/apache/kafka/pull/15802#discussion_r1579702459 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -91,65 +91,97 @@ public void

Re: [PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
chia7712 commented on PR #15802: URL: https://github.com/apache/kafka/pull/15802#issuecomment-2076758475 @FrankYang0529 We reuse the TOPIC and GROUP in the for-loop, and that could be a issue if the cleanup of topic/group is not finished before running next loop. Could you please use

[PR] MINOR: refine DeleteOffsetsConsumerGroupCommandIntegrationTest#produceRecord [kafka]

2024-04-25 Thread via GitHub
FrankYang0529 opened a new pull request, #15802: URL: https://github.com/apache/kafka/pull/15802 Use try-with-resource to create producer and make sure the producer send record without error. ### Committer Checklist (excluded from commit message) - [ ] Verify design and