Re: [PR] MINOR: remove redundnat list initialization [kafka]

2024-04-04 Thread via GitHub
chia7712 merged PR #15641: URL: https://github.com/apache/kafka/pull/15641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: remove redundnat list initialization [kafka]

2024-04-01 Thread via GitHub
chia7712 commented on code in PR #15641: URL: https://github.com/apache/kafka/pull/15641#discussion_r1547036167 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -1213,8 +1210,9 @@ private void clearAll() { }

[PR] MINOR: remove redundnat list initialization [kafka]

2024-04-01 Thread via GitHub
brandboat opened a new pull request, #15641: URL: https://github.com/apache/kafka/pull/15641 in CommitRequestManager.java, some code snippet create an empty list and add another list to the empty list, we can avoid this kind of redundant list initialization to gain a little better