Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-13 Thread via GitHub
mjsax merged PR #15519: URL: https://github.com/apache/kafka/pull/15519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-12 Thread via GitHub
mjsax commented on PR #15519: URL: https://github.com/apache/kafka/pull/15519#issuecomment-1992854817 PR update does not show up right now. Github Status page: > Update - We're continuing to investigate an elevated number of pull requests that are out of sync on page load. Mar 13,

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-12 Thread via GitHub
mjsax commented on PR #15519: URL: https://github.com/apache/kafka/pull/15519#issuecomment-1992841168 Thank for all the input! -- Updated the PR accordinly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-12 Thread via GitHub
lianetm commented on code in PR #15519: URL: https://github.com/apache/kafka/pull/15519#discussion_r1521497910 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-12 Thread via GitHub
dajac commented on code in PR #15519: URL: https://github.com/apache/kafka/pull/15519#discussion_r1520969629 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
chia7712 commented on code in PR #15519: URL: https://github.com/apache/kafka/pull/15519#discussion_r1520683129 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
mjsax commented on code in PR #15519: URL: https://github.com/apache/kafka/pull/15519#discussion_r1520582633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
chia7712 commented on code in PR #15519: URL: https://github.com/apache/kafka/pull/15519#discussion_r1520572340 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,10 +529,9 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
mjsax commented on PR #15519: URL: https://github.com/apache/kafka/pull/15519#issuecomment-1989525897 Follow up from https://github.com/apache/kafka/pull/15419/files#r1513841644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] MINOR: simplify consumer logic [kafka]

2024-03-11 Thread via GitHub
mjsax opened a new pull request, #15519: URL: https://github.com/apache/kafka/pull/15519 For static member, the `group.instance.id` cannot change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to