Re: [PR] cherrypick KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-04-25 Thread via GitHub
jolshan merged PR #15755: URL: https://github.com/apache/kafka/pull/15755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] cherrypick KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-04-24 Thread via GitHub
dajac commented on PR #15755: URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075368110 @jolshan That makes sense. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] cherrypick KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-04-24 Thread via GitHub
jolshan commented on PR #15755: URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075323626 Hey @dajac thanks for taking a look. We didn't include https://github.com/apache/kafka/commit/a8203f9c7a2c449ee59ee29d775409b2f1e00d07 in 3.7 so I feel like adding this code is

Re: [PR] cherrypick KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-04-24 Thread via GitHub
dajac commented on PR #15755: URL: https://github.com/apache/kafka/pull/15755#issuecomment-2074307269 @jolshan Thanks for the PR. Is there a reason why you removed [216cc9d](https://github.com/apache/kafka/pull/15755/commits/216cc9dce46b7837282bd67bfab06ec045c9902c)? It does not apply 1:1

[PR] cherrypick KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-04-18 Thread via GitHub
jolshan opened a new pull request, #15755: URL: https://github.com/apache/kafka/pull/15755 KIP-890 Part 1 introduced verification of transactions with the transaction coordinator on the `Produce` and `TxnOffsetCommit` paths. This introduced the possibility of new errors when responding to