[GitHub] [kafka] showuon commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-05 Thread via GitHub
showuon commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1536156206 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.clients.consumer.internals.AbstractCoordinatorTest.testBackoffAndRetryUponRetriableError()

[GitHub] [kafka] divijvaidya commented on pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-05 Thread via GitHub
divijvaidya commented on PR #13623: URL: https://github.com/apache/kafka/pull/13623#issuecomment-1536155781 Thank you @dajac. Appreciate your time and patience on this PR.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (KAFKA-14969) Upgrade Mockito to 4.11.0

2023-05-05 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719865#comment-17719865 ] Ismael Juma commented on KAFKA-14969: - I thought we should go straight to 5.x when we drop support

[GitHub] [kafka] vvcephei commented on pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-05-05 Thread via GitHub
vvcephei commented on PR #13633: URL: https://github.com/apache/kafka/pull/13633#issuecomment-1536478379 Actually, @mjsax , I do have one question before merging: Are there classes that are meant to be overridden by users? If so, should their protected members be documented? -- This is

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13673: MINOR: Update dependencies (minor versions only)

2023-05-05 Thread via GitHub
divijvaidya commented on code in PR #13673: URL: https://github.com/apache/kafka/pull/13673#discussion_r1185999578 ## gradle/dependencies.gradle: ## @@ -142,7 +142,7 @@ libs += [ apachedsMavibotPartition:

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13673: MINOR: Update dependencies (minor versions only)

2023-05-05 Thread via GitHub
divijvaidya commented on code in PR #13673: URL: https://github.com/apache/kafka/pull/13673#discussion_r1185999578 ## gradle/dependencies.gradle: ## @@ -142,7 +142,7 @@ libs += [ apachedsMavibotPartition:

[jira] [Resolved] (KAFKA-14926) Remove metrics on Log Cleaner shutdown

2023-05-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-14926. - Resolution: Fixed > Remove metrics on Log Cleaner shutdown >

[GitHub] [kafka] divijvaidya commented on pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-05 Thread via GitHub
divijvaidya commented on PR #13312: URL: https://github.com/apache/kafka/pull/13312#issuecomment-1536165039 Thank you @showuon and @ijuma for your time and patience in this review  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] clayburn commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-05 Thread via GitHub
clayburn commented on code in PR #13676: URL: https://github.com/apache/kafka/pull/13676#discussion_r1186205824 ## settings.gradle: ## @@ -13,6 +13,38 @@ // See the License for the specific language governing permissions and // limitations under the License. +plugins { +

[GitHub] [kafka] showuon merged pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-05 Thread via GitHub
showuon merged PR #13312: URL: https://github.com/apache/kafka/pull/13312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-14968) Consumer Notification Callback

2023-05-05 Thread Hendrik Jan van Randen (Jira)
Hendrik Jan van Randen created KAFKA-14968: -- Summary: Consumer Notification Callback Key: KAFKA-14968 URL: https://issues.apache.org/jira/browse/KAFKA-14968 Project: Kafka Issue

[jira] [Commented] (KAFKA-14698) Received request api key LEADER_AND_ISR which is not enabled

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719886#comment-17719886 ] Mickael Maison commented on KAFKA-14698: [~akhileshchg]/[~mumrah] What's the status of this

[GitHub] [kafka] vvcephei commented on a diff in pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-05-05 Thread via GitHub
vvcephei commented on code in PR #13633: URL: https://github.com/apache/kafka/pull/13633#discussion_r1186269574 ## build.gradle: ## @@ -2057,6 +2057,7 @@ project(':streams') { srcJar.dependsOn 'processMessages' javadoc { +options.memberLevel =

[GitHub] [kafka] showuon commented on pull request #13660: KAFKA-14662: Update the ACL list in the doc

2023-05-05 Thread via GitHub
showuon commented on PR #13660: URL: https://github.com/apache/kafka/pull/13660#issuecomment-1536155265 Retriggering the CI build since it failed with infra's issue. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13660/3/ -- This is an automated message from the Apache Git

[jira] [Commented] (KAFKA-14805) KRaft Controller shouldn't allow metadata updates before migration starts

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719878#comment-17719878 ] Mickael Maison commented on KAFKA-14805: [~mumrah] The associated PR is merged, is this work

[jira] [Resolved] (KAFKA-14859) Support SCRAM ZK to KRaft Migration

2023-05-05 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano resolved KAFKA-14859. --- Resolution: Fixed Merged into trunk and 3.5 > Support SCRAM ZK to KRaft Migration

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719922#comment-17719922 ] Mickael Maison commented on KAFKA-14084: So I think we could close this ticket, as effectively

[GitHub] [kafka] rohits64 opened a new pull request, #13677: KAFKA-14401 with test [WIP]

2023-05-05 Thread via GitHub
rohits64 opened a new pull request, #13677: URL: https://github.com/apache/kafka/pull/13677 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] chia7712 commented on pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-05 Thread via GitHub
chia7712 commented on PR #13659: URL: https://github.com/apache/kafka/pull/13659#issuecomment-1536128806 failed tests are unrelated. Will merge it later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (KAFKA-14918) KRaft controller sending ZK controller RPCs to KRaft brokers

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719880#comment-17719880 ] Mickael Maison commented on KAFKA-14918: Ping [~mumrah] can you share an update? Otherwise I'll

[jira] [Commented] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719885#comment-17719885 ] Mickael Maison commented on KAFKA-14831: Is this near completion? If not I'll move this out of

[GitHub] [kafka] clayburn commented on pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-05 Thread via GitHub
clayburn commented on PR #13676: URL: https://github.com/apache/kafka/pull/13676#issuecomment-1536412348 > Thank you for the contribution. > > It would be super helpful (perhaps outside of this PR) if you could add a section in our documentation [1] on how to monitor the result of

[GitHub] [kafka] rohits64 commented on pull request #13677: KAFKA-14401 with test [WIP]

2023-05-05 Thread via GitHub
rohits64 commented on PR #13677: URL: https://github.com/apache/kafka/pull/13677#issuecomment-1536165839 Duplicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] rohits64 closed pull request #13677: KAFKA-14401 with test [WIP]

2023-05-05 Thread via GitHub
rohits64 closed pull request #13677: KAFKA-14401 with test [WIP] URL: https://github.com/apache/kafka/pull/13677 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (KAFKA-14969) Upgrade Mockito to 4.11.0

2023-05-05 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14969: Summary: Upgrade Mockito to 4.11.0 Key: KAFKA-14969 URL: https://issues.apache.org/jira/browse/KAFKA-14969 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] lucasbru commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
lucasbru commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1186098795 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map> activeTasks,

[jira] [Commented] (KAFKA-14901) Flaky test ExactlyOnceSourceIntegrationTest.testConnectorReconfiguration

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719868#comment-17719868 ] Mickael Maison commented on KAFKA-14901: [~gharris1727] Do you think this is a blocker for 3.5?

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

2023-05-05 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719899#comment-17719899 ] Proven Provenzano commented on KAFKA-14084: --- [~mimaison] The last commit for SCRAM migration

[GitHub] [kafka] clayburn commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-05 Thread via GitHub
clayburn commented on code in PR #13676: URL: https://github.com/apache/kafka/pull/13676#discussion_r1186202287 ## settings.gradle: ## @@ -13,6 +13,38 @@ // See the License for the specific language governing permissions and // limitations under the License. +plugins { +

[GitHub] [kafka] showuon commented on pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-05 Thread via GitHub
showuon commented on PR #13515: URL: https://github.com/apache/kafka/pull/13515#issuecomment-1536153857 Retriggering the CI build since it failed with some infra's issue. https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13515/8/ -- This is an automated message from the Apache

[jira] [Assigned] (KAFKA-14968) Consumer Notification Callback

2023-05-05 Thread Hendrik Jan van Randen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hendrik Jan van Randen reassigned KAFKA-14968: -- Assignee: Hendrik Jan van Randen > Consumer Notification Callback >

[jira] [Updated] (KAFKA-14968) Consumer Notification Callback

2023-05-05 Thread Hendrik Jan van Randen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hendrik Jan van Randen updated KAFKA-14968: --- Description: We want to use Kafka for all the communication between our

[GitHub] [kafka] divijvaidya commented on pull request #13670: KAFKA-14962: Trim whitespace from ACL configuration

2023-05-05 Thread via GitHub
divijvaidya commented on PR #13670: URL: https://github.com/apache/kafka/pull/13670#issuecomment-1536300068 The failing tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / testElectUncleanLeadersForOnePartition(String).quorum=kraft – kafka.api.PlaintextAdminIntegrationTest 26s

[jira] [Commented] (KAFKA-14840) Handle KRaft snapshots in dual-write mode

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719881#comment-17719881 ] Mickael Maison commented on KAFKA-14840: [~mumrah] The associated PR is merged, is this now

[GitHub] [kafka] dajac merged pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-05 Thread via GitHub
dajac merged PR #13623: URL: https://github.com/apache/kafka/pull/13623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719877#comment-17719877 ] Mickael Maison commented on KAFKA-14084: [~cmccabe]/[~pprovenzano] What is the status of this?

[jira] [Updated] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14831: -- Reviewer: Justine Olshan > Illegal state errors should be fatal in transactional producer >

[jira] [Updated] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14831: -- Description: In KAFKA-14830, the producer hit an illegal state error. The error was propagated to the

[jira] [Commented] (KAFKA-14961) DefaultBackgroundThreadTest.testStartupAndTearDown test is flasky

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719933#comment-17719933 ] Kirk True commented on KAFKA-14961: --- cc [~pnee] [~lianetm]  >

[GitHub] [kafka] wenbingshen closed pull request #10625: MINOR: Fix error log for bounce broker

2023-05-05 Thread via GitHub
wenbingshen closed pull request #10625: MINOR: Fix error log for bounce broker URL: https://github.com/apache/kafka/pull/10625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] wenbingshen opened a new pull request, #10625: MINOR: Fix error log for bounce broker

2023-05-05 Thread via GitHub
wenbingshen opened a new pull request, #10625: URL: https://github.com/apache/kafka/pull/10625 bounce leader broker for topic partition was mistakenly log as a follower broker ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[jira] [Updated] (KAFKA-14968) Consumer Notification Callback

2023-05-05 Thread Hendrik Jan van Randen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hendrik Jan van Randen updated KAFKA-14968: --- Description: We want to use Kafka for all the communication between our

[GitHub] [kafka] jolshan commented on pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-05 Thread via GitHub
jolshan commented on PR #13591: URL: https://github.com/apache/kafka/pull/13591#issuecomment-1536545551 https://github.com/apache/kafka/commit/ea81e99e5980c807414651034a8c60426a158ca4 added TransitionToUnitialized. Can we confirm this has the behavior we expect? I believe this would count

[GitHub] [kafka] mjsax commented on pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-05-05 Thread via GitHub
mjsax commented on PR #13633: URL: https://github.com/apache/kafka/pull/13633#issuecomment-1536581114 Thank @vvcephei -- for K14839 in particular, it's nothing users should overwrite, in fact, they should not even extend the class in question at all. I did not double check in general

[GitHub] [kafka] chia7712 merged pull request #13659: MINOR: add docs to remind reader that impl of ConsumerPartitionAssign…

2023-05-05 Thread via GitHub
chia7712 merged PR #13659: URL: https://github.com/apache/kafka/pull/13659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-14084) Support SCRAM when using KRaft mode

2023-05-05 Thread Proven Provenzano (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Proven Provenzano resolved KAFKA-14084. --- Resolution: Fixed SCRAM support in KRaft is implemented. Test of SCRAM

[GitHub] [kafka] junrao commented on a diff in pull request #13503: MINOR: Refactor TierStateMachine related tests into a separate test file

2023-05-05 Thread via GitHub
junrao commented on code in PR #13503: URL: https://github.com/apache/kafka/pull/13503#discussion_r1186548617 ## core/src/test/scala/unit/kafka/server/ReplicaFetcherTierStateMachineTest.scala: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] mjsax commented on a diff in pull request #13633: KAFKA-14839: Exclude protected variable from JavaDocs

2023-05-05 Thread via GitHub
mjsax commented on code in PR #13633: URL: https://github.com/apache/kafka/pull/13633#discussion_r1186357597 ## build.gradle: ## @@ -2057,6 +2057,7 @@ project(':streams') { srcJar.dependsOn 'processMessages' javadoc { +options.memberLevel = JavadocMemberLevel.PUBLIC

[jira] [Commented] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719988#comment-17719988 ] Kirk True commented on KAFKA-14831: --- Sounds good, [~jolshan]. I updated the fix version to 3.6.0.

[jira] [Updated] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-14831: -- Fix Version/s: 3.6.0 (was: 3.5.0) > Illegal state errors should be fatal in

[jira] [Commented] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719992#comment-17719992 ] Mickael Maison commented on KAFKA-14831: Thanks! > Illegal state errors should be fatal in

[jira] [Commented] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719931#comment-17719931 ] Kirk True commented on KAFKA-14831: --- [~jolshan] has been providing most of the feedback on the PR.

[GitHub] [kafka] vvcephei commented on pull request #13455: KAFKA-14841 Handle callbacks to ConsumerRebalanceListener in MockConsumer

2023-05-05 Thread via GitHub
vvcephei commented on PR #13455: URL: https://github.com/apache/kafka/pull/13455#issuecomment-1536829632 There were a lot of test failures. I just triggered it again. It doesn't seem implausible that changing the MockConsumer could cause other tests to fail, but I didn't look at

[jira] [Assigned] (KAFKA-14791) Create a builder class for PartitionRegistration

2023-05-05 Thread Andrew Grant (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Grant reassigned KAFKA-14791: Assignee: Andrew Grant > Create a builder class for PartitionRegistration >

[jira] [Created] (KAFKA-14970) Dual write mode testing for SCRAM and Quota

2023-05-05 Thread Proven Provenzano (Jira)
Proven Provenzano created KAFKA-14970: - Summary: Dual write mode testing for SCRAM and Quota Key: KAFKA-14970 URL: https://issues.apache.org/jira/browse/KAFKA-14970 Project: Kafka Issue

[jira] [Commented] (KAFKA-14084) Support SCRAM when using KRaft mode

2023-05-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719993#comment-17719993 ] Mickael Maison commented on KAFKA-14084: Thanks! > Support SCRAM when using KRaft mode >

[GitHub] [kafka] vvcephei commented on pull request #13664: KAFKA-14961: harden DefaultBackgroundThreadTest.testStartupAndTearDown test

2023-05-05 Thread via GitHub
vvcephei commented on PR #13664: URL: https://github.com/apache/kafka/pull/13664#issuecomment-1536827381 I'm re-running the tests to see if we can get a green build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] jolshan commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-05 Thread via GitHub
jolshan commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1186307624 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -0,0 +1,445 @@ +/* + * Licensed to the Apache

[jira] [Commented] (KAFKA-14831) Illegal state errors should be fatal in transactional producer

2023-05-05 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719941#comment-17719941 ] Justine Olshan commented on KAFKA-14831: I guess I had assumed we missed the code freeze and

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185968862 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -262,6 +262,42 @@ private void closeDirtyAndRevive(final Collection

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185970601 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185973531 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185974966 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185975845 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185979279 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,18 @@ public void handleAssignment(final Map>

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #11433: KAFKA-13295: Avoiding Transation timeouts arising due to long restora…

2023-05-05 Thread via GitHub
vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185978385 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -342,7 +342,19 @@ public void handleAssignment(final Map>

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-05 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1185727238 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,164 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-05 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1185727238 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,164 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] showuon commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-05 Thread via GitHub
showuon commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1185732188 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,164 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] dajac commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-05 Thread via GitHub
dajac commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1185749017 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] fvaleri commented on a diff in pull request #13515: KAFKA-14752: Kafka examples improvements - producer changes

2023-05-05 Thread via GitHub
fvaleri commented on code in PR #13515: URL: https://github.com/apache/kafka/pull/13515#discussion_r1185727238 ## examples/src/main/java/kafka/examples/Producer.java: ## @@ -21,133 +21,164 @@ import org.apache.kafka.clients.producer.ProducerConfig; import

[GitHub] [kafka] dajac commented on a diff in pull request #13638: KAFKA-14462; [11/N] Add CurrentAssignmentBuilder

2023-05-05 Thread via GitHub
dajac commented on code in PR #13638: URL: https://github.com/apache/kafka/pull/13638#discussion_r1185752497 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilderTest.java: ## @@ -0,0 +1,558 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cmccabe merged pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

2023-05-05 Thread via GitHub
cmccabe merged PR #13461: URL: https://github.com/apache/kafka/pull/13461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka] cmccabe commented on pull request #12331: KAFKA-1194: changes needed to run on Windows

2023-05-05 Thread via GitHub
cmccabe commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-1535924639 > @Hangleton : Agree that this change should be ideally confined to the Windows platform w/o any code change for others. Yeah. To be totally clear, it's OK to change the main code

[GitHub] [kafka] bmscomp commented on pull request #13662: MINOR: Upgrade Jackson dependencies to version 2.15.0

2023-05-05 Thread via GitHub
bmscomp commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1535937778 @divijvaidya I get your point, thanks so much for those explanations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-05 Thread via GitHub
urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1185797643 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() { }

[GitHub] [kafka] clolov commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

2023-05-05 Thread via GitHub
clolov commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1185861417 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13676: MINOR: Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-05 Thread via GitHub
divijvaidya commented on code in PR #13676: URL: https://github.com/apache/kafka/pull/13676#discussion_r1185859941 ## settings.gradle: ## @@ -13,6 +13,38 @@ // See the License for the specific language governing permissions and // limitations under the License. +plugins { +

[GitHub] [kafka] huxiangquan commented on pull request #12331: KAFKA-1194: changes needed to run on Windows

2023-05-05 Thread via GitHub
huxiangquan commented on PR #12331: URL: https://github.com/apache/kafka/pull/12331#issuecomment-1536010891 Can someone help kafka on windows , please? Two years have passed ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-14805) KRaft Controller shouldn't allow metadata updates before migration starts

2023-05-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14805: -- Fix Version/s: (was: 3.4.1) > KRaft Controller shouldn't allow metadata updates before migration

[jira] [Resolved] (KAFKA-14963) Incorrect partition count metrics for kraft controllers

2023-05-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14963. --- Resolution: Fixed > Incorrect partition count metrics for kraft controllers >

[GitHub] [kafka] divijvaidya commented on pull request #13662: MINOR: Upgrade Jackson dependencies to version 2.15.0

2023-05-05 Thread via GitHub
divijvaidya commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1535880466 @bmscomp this is a nice PR and I support it. I opened the other one ( https://github.com/apache/kafka/pull/13673 ) for minor versions upgrades because minor versions have a lower

[GitHub] [kafka] divijvaidya commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

2023-05-05 Thread via GitHub
divijvaidya commented on PR #13421: URL: https://github.com/apache/kafka/pull/13421#issuecomment-1535884087 @hudeqi thanks for reminding me about this. I will review it next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Assigned] (KAFKA-14514) Implement range broker side assignor

2023-05-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14514: --- Assignee: David Jacot > Implement range broker side assignor >

[jira] [Assigned] (KAFKA-14515) Implement uniform broker side assignor

2023-05-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14515: --- Assignee: David Jacot > Implement uniform broker side assignor >

[jira] [Assigned] (KAFKA-14501) Implement Heartbeat API

2023-05-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14501: --- Assignee: Jeff Kim > Implement Heartbeat API > --- > >

[GitHub] [kafka] Hangleton commented on a diff in pull request #13240: KAFKA-14690: Add topic IDs to the OffsetCommit API version 9

2023-05-05 Thread via GitHub
Hangleton commented on code in PR #13240: URL: https://github.com/apache/kafka/pull/13240#discussion_r1185779424 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -2707,11 +2742,271 @@ public void

[jira] [Assigned] (KAFKA-14502) Implement LeaveGroup API

2023-05-05 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-14502: --- Assignee: Jeff Kim > Implement LeaveGroup API > > >

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-05 Thread via GitHub
divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1185820116 ## clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java: ## @@ -241,6 +244,119 @@ public void testDouble() throws IOException {

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-05 Thread via GitHub
divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1185820299 ## clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java: ## @@ -241,6 +244,119 @@ public void testDouble() throws IOException {