jeqo commented on PR #13923:
URL: https://github.com/apache/kafka/pull/13923#issuecomment-1611590682
Sure, make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
divijvaidya merged PR #13922:
URL: https://github.com/apache/kafka/pull/13922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jeffkbkim commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245495804
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245609479
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1245628587
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -240,17 +240,18 @@ object RequestChannel extends Logging {
val responseSendTimeMs =
divijvaidya commented on PR #13902:
URL: https://github.com/apache/kafka/pull/13902#issuecomment-1611682088
@mumrah Should we backport this for 3.5 branch as well since the code that
introduced this flakiness exists over there as well?
--
This is an automated message from the Apache Git
Edoardo Comar created KAFKA-15133:
-
Summary: RequestMetrics MessageConversionsTimeMs count is ticked
even when no conversion occurs
Key: KAFKA-15133
URL: https://issues.apache.org/jira/browse/KAFKA-15133
jeffkbkim commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245489701
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
dajac commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611790598
@flashmouse Thanks for the PR. It seems that this condition has been around
for a while now. Did you observe a similar issue with version prior to 3.5? I
wonder what if changes introduced
vcrfxia commented on PR #13855:
URL: https://github.com/apache/kafka/pull/13855#issuecomment-1611889559
Hey @wcarlson5 did you mean to push a new commit to this PR since @cadonna
and I last reviewed? Some of your replies mention having made changes but I
don't see any.
Nothing
divijvaidya merged PR #13884:
URL: https://github.com/apache/kafka/pull/13884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
jolshan commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1611687116
Thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hudeqi opened a new pull request, #13926:
URL: https://github.com/apache/kafka/pull/13926
This pr is used to remove the metrics in GroupMetadataManager when shutdown.
This pr has passed the corresponding unit test, and it is part of
guizmaii commented on code in PR #13914:
URL: https://github.com/apache/kafka/pull/13914#discussion_r1245542620
##
clients/src/main/java/org/apache/kafka/clients/consumer/ThreadAccessKey.java:
##
@@ -0,0 +1,8 @@
+package org.apache.kafka.clients.consumer;
+
+/**
+ * A key that
artemlivshits commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1245541275
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -240,17 +240,18 @@ object RequestChannel extends Logging {
val responseSendTimeMs =
jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1245629399
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -240,17 +240,18 @@ object RequestChannel extends Logging {
val responseSendTimeMs =
[
https://issues.apache.org/jira/browse/KAFKA-15028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-15028.
Resolution: Fixed
> AddPartitionsToTxnManager metrics
> -
lucasbru commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245383102
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,35 @@ public void signalResume() {
public Map
[
https://issues.apache.org/jira/browse/KAFKA-15132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738189#comment-17738189
]
Divij Vaidya commented on KAFKA-15132:
--
I and [~mehbey] are currently working on drafting a KIP for
jolshan merged PR #13798:
URL: https://github.com/apache/kafka/pull/13798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13923:
URL: https://github.com/apache/kafka/pull/13923#issuecomment-1611589151
Thanks @jeqo. Looks good to me but we will wait for Luke and/or Satish to
look into this before we merge this one in.
--
This is an automated message from the Apache Git Service.
dajac commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245517961
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lucasbru commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245664165
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,33 @@ public void signalResume() {
public Map
lucasbru commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245427580
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,33 @@ public void signalResume() {
public Map
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611775967
@rreddy-22 that's what I mean, thank you, could any one merge this if
possible or help review to verify this pr is useful?
we are now using CooperativeSticky strategy in
jolshan commented on PR #13591:
URL: https://github.com/apache/kafka/pull/13591#issuecomment-1611816013
Some new test failures on latest build. I will rebuild and investigate to
see if this is new to trunk.
--
This is an automated message from the Apache Git Service.
To respond to the
flashmouse commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611815006
@dajac
we haven't seen such many rebalance times before, we before use
CooperativeSticky with kafka-client 3.0.0, rebalance times increase very slight.
but we are not use
ijuma commented on code in PR #12948:
URL: https://github.com/apache/kafka/pull/12948#discussion_r124885
##
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##
@@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException {
//
chia7712 merged PR #13902:
URL: https://github.com/apache/kafka/pull/13902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245477150
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,33 @@ public void signalResume() {
public Map
jeffkbkim commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245486249
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java:
##
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation
cadonna opened a new pull request, #13927:
URL: https://github.com/apache/kafka/pull/13927
Now that the implementation for the state updater is done, we can enable it
by default.
This PR enables the state updater by default and fixes code that made
assumptions that are not true when
[
https://issues.apache.org/jira/browse/KAFKA-15133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738205#comment-17738205
]
Edoardo Comar commented on KAFKA-15133:
---
[~rsivaram] - reading KIP 188
I am not sure if the
jeffkbkim commented on code in PR #13880:
URL: https://github.com/apache/kafka/pull/13880#discussion_r1245523659
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-15083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738216#comment-17738216
]
Satish Duggana commented on KAFKA-15083:
[~showuon] Can you give details on what you tried?
>
rreddy-22 commented on PR #13920:
URL: https://github.com/apache/kafka/pull/13920#issuecomment-1611886952
> @flashmouse Thanks for the PR. It seems that this condition has been
around for a while now. Did you observe a similar issue with version prior to
3.5? I wonder what if changes
jeffkbkim commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245712559
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -141,7 +141,7 @@ public static class TimeAndEpoch {
*
jeffkbkim commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245682672
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -728,6 +794,81 @@ public void replay(
}
cadonna commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245477150
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,33 @@ public void signalResume() {
public Map
[
https://issues.apache.org/jira/browse/KAFKA-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738231#comment-17738231
]
Matthias J. Sax commented on KAFKA-13973:
-
The GitHub issue for RocksDB was "declined". I did
C0urante commented on code in PR #13446:
URL: https://github.com/apache/kafka/pull/13446#discussion_r1245885579
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##
@@ -150,10 +156,31 @@ private void loadInitialConsumerGroups()
stevenbooke commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1245890763
##
refresh-collaborators.py:
##
@@ -0,0 +1,44 @@
+import os
+from bs4 import BeautifulSoup
+from github import Github
+import yaml
+
+### GET THE NAMES OF THE
jsancio merged PR #13917:
URL: https://github.com/apache/kafka/pull/13917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
xiaocairush commented on PR #13928:
URL: https://github.com/apache/kafka/pull/13928#issuecomment-1612416149
Hi @pgjbz , could u kind please share which thread has deleted the log file?
I'm a newbie for kafka source code and cannot find the root cause.
--
This is an automated message from
pgjbz opened a new pull request, #13928:
URL: https://github.com/apache/kafka/pull/13928
catch NoSuchFileException on atomicMoveWithFallback this catch block will
prevent throws NoSuchFileException and stop kafka server in Kraft Mode
### Committer Checklist (excluded from commit
[
https://issues.apache.org/jira/browse/KAFKA-15078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-15078.
Fix Version/s: 3.6.0
Resolution: Fixed
> When fetching
C0urante commented on code in PR #13658:
URL: https://github.com/apache/kafka/pull/13658#discussion_r1245804801
##
docs/configuration.html:
##
@@ -267,23 +267,31 @@
- 3.8 System
Properties
+
+ 3.8 MirrorMaker
Configs
+ Below is the configuration of MirrorMaker.
Review
stevenbooke commented on code in PR #13842:
URL: https://github.com/apache/kafka/pull/13842#discussion_r1245887810
##
refresh-collaborators.py:
##
@@ -0,0 +1,44 @@
+import os
+from bs4 import BeautifulSoup
+from github import Github
+import yaml
+
+### GET THE NAMES OF THE
junrao commented on code in PR #13898:
URL: https://github.com/apache/kafka/pull/13898#discussion_r1245887623
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java:
##
@@ -117,11 +104,6 @@ else if (timestamp ==
jsancio commented on PR #13917:
URL: https://github.com/apache/kafka/pull/13917#issuecomment-1612214700
> @jsancio Another difference is that now the `outer` exception's stack
trace will be shown via `WARN` instead of just the exception's message via
`DEBUG`. I assume that's intentional,
jsancio merged PR #13845:
URL: https://github.com/apache/kafka/pull/13845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
divijvaidya commented on PR #13798:
URL: https://github.com/apache/kafka/pull/13798#issuecomment-1611605733
> so only that one verification per transaction
ah, I had missed this part that it will not be recorded on "every" message
append. Only for verified cases. I think we should be
Divij Vaidya created KAFKA-15132:
Summary: Implement disable & re-enablement for Tiered Storage
Key: KAFKA-15132
URL: https://issues.apache.org/jira/browse/KAFKA-15132
Project: Kafka
Issue
C0urante commented on code in PR #13915:
URL: https://github.com/apache/kafka/pull/13915#discussion_r1245532682
##
docs/connect.html:
##
@@ -313,7 +313,13 @@ REST
API
DELETE /connectors/{name} - delete a connector,
halting all tasks and deleting its configuration
C0urante commented on code in PR #13915:
URL: https://github.com/apache/kafka/pull/13915#discussion_r1245532972
##
docs/connect.html:
##
@@ -301,7 +301,7 @@ REST
API
GET /connectors/{name}/tasks - get a list of tasks
currently running for a connector
GET
lucasbru commented on code in PR #13925:
URL: https://github.com/apache/kafka/pull/13925#discussion_r1245664165
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1138,28 +1138,33 @@ public void signalResume() {
public Map
wcarlson5 commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1244729657
##
streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java:
##
@@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final
Serde otherValueSerde) {
wcarlson5 commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1244739834
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##
@@ -56,10 +77,59 @@ public void init(final ProcessorContext
wcarlson5 commented on code in PR #13855:
URL: https://github.com/apache/kafka/pull/13855#discussion_r1244730962
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##
@@ -56,10 +77,59 @@ public void init(final ProcessorContext
hudeqi created KAFKA-15129:
--
Summary: Clean up all metrics that were forgotten to be closed
Key: KAFKA-15129
URL: https://issues.apache.org/jira/browse/KAFKA-15129
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-15130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lan Ding updated KAFKA-15130:
-
Description: When tiered storage is enabled and
{{delete.topic.enable=true}} , deleting a topic should
[
https://issues.apache.org/jira/browse/KAFKA-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
hudeqi updated KAFKA-15129:
---
Description:
In the current kafka code, there are still many module metrics that are
forgotten to be
tinaselenge commented on PR #13760:
URL: https://github.com/apache/kafka/pull/13760#issuecomment-1610960042
Thank you @showuon for the feedback. I think I have addressed the comments.
Please let me know there is anything I missed or doesn't look right.
--
This is an automated message
Lan Ding created KAFKA-15130:
Summary: Delete remote segments when delete a topic
Key: KAFKA-15130
URL: https://issues.apache.org/jira/browse/KAFKA-15130
Project: Kafka
Issue Type: Improvement
erikvanoosten commented on PR #13914:
URL: https://github.com/apache/kafka/pull/13914#issuecomment-1610983180
KIP-944 has been created: https://cwiki.apache.org/confluence/x/chw0Dw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik van Oosten updated KAFKA-14972:
Description:
KafkaConsumer contains a check that rejects nested invocations from
[
https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erik van Oosten updated KAFKA-14972:
Description:
KafkaConsumer contains a check that rejects nested invocations from
[
https://issues.apache.org/jira/browse/KAFKA-14972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738014#comment-17738014
]
Erik van Oosten commented on KAFKA-14972:
-
KIP-944 https://cwiki.apache.org/confluence/x/chw0Dw
[
https://issues.apache.org/jira/browse/KAFKA-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738033#comment-17738033
]
Jorge Esteban Quilcate Otoya commented on KAFKA-14993:
--
[~ckamal] just checking if
[
https://issues.apache.org/jira/browse/KAFKA-14993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738035#comment-17738035
]
Kamal Chandraprakash commented on KAFKA-14993:
--
[~jeqo] I haven't started to work on this
joobisb commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1245058126
##
docs/quickstart.html:
##
@@ -154,9 +154,9 @@
By default, each line you enter will result in a separate event
being written to the topic.
joobisb commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1245057900
##
docs/quickstart.html:
##
@@ -32,7 +32,7 @@
the latest Kafka release and extract it:
-$ tar -xzf
[
https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738081#comment-17738081
]
Josep Prat commented on KAFKA-15105:
Hi [~riedelmax] ,
Only maintainers + a subgroup of
[
https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat updated KAFKA-15105:
---
Description:
Test
[
https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738081#comment-17738081
]
Josep Prat edited comment on KAFKA-15105 at 6/28/23 12:03 PM:
--
Hi
Jorge Esteban Quilcate Otoya created KAFKA-15131:
Summary: Improve RemoteStorageManager exception handling
Key: KAFKA-15131
URL: https://issues.apache.org/jira/browse/KAFKA-15131
jeqo opened a new pull request, #13923:
URL: https://github.com/apache/kafka/pull/13923
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
[
https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christo Lolov updated KAFKA-14133:
--
Description:
{color:#de350b}There are tests which use both PowerMock and EasyMock. I have
[
https://issues.apache.org/jira/browse/KAFKA-15131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jorge Esteban Quilcate Otoya updated KAFKA-15131:
-
Summary: Improve RemoteStorageManager exception handling
[
https://issues.apache.org/jira/browse/KAFKA-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738060#comment-17738060
]
David Gammon commented on KAFKA-15116:
--
Hi [~mjsax], please see my responses below:
# Message A
[
https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738077#comment-17738077
]
Max Riedel commented on KAFKA-15105:
Hi [~josep.prat]
Thanks for giving me the necessary Jira
divijvaidya commented on code in PR #13923:
URL: https://github.com/apache/kafka/pull/13923#discussion_r1245118305
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -107,20 +110,22 @@ InputStream
jeqo commented on PR #13828:
URL: https://github.com/apache/kafka/pull/13828#issuecomment-1611155345
@showuon I'm trying to test this, but TBRLMM is still complaining about
missing bootstrap.servers, even when listener name is provided:
```
kafka-ts | [2023-06-28 10:19:04,131] INFO
[
https://issues.apache.org/jira/browse/KAFKA-15105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Max Riedel reassigned KAFKA-15105:
--
Assignee: Max Riedel
> Flaky test
>
showuon commented on PR #13923:
URL: https://github.com/apache/kafka/pull/13923#issuecomment-1611315037
I'll take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245148023
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -88,10 +93,12 @@ public class GroupMetadataManager {
public
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245154086
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -506,32 +555,54 @@ private
CoordinatorResult consumerGr
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245157302
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1021,34 @@ public void replay(
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245209953
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -874,4 +1021,34 @@ public void replay(
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245212300
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -119,6 +131,18 @@ public String toString() {
*/
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245226991
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -141,7 +141,7 @@ public static class TimeAndEpoch {
*
dajac commented on PR #13880:
URL: https://github.com/apache/kafka/pull/13880#issuecomment-1611323500
@jolshan Thanks. I have addressed the remaining comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245156156
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -709,14 +780,16 @@ public void replay(
String groupId =
hudeqi opened a new pull request, #13924:
URL: https://github.com/apache/kafka/pull/13924
This pr is used to remove the metrics in LogCleanerManager when logCleaner
is closed.
This pr has passed the corresponding unit test, and it is part of
KAFKA-15129.
--
This is an automated
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245214287
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -423,6 +456,47 @@ public Map
computeSubscriptionMetadata(
dajac commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1245213037
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -423,6 +456,47 @@ public Map
computeSubscriptionMetadata(
jeqo commented on code in PR #13923:
URL: https://github.com/apache/kafka/pull/13923#discussion_r1245252224
##
storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageManager.java:
##
@@ -107,20 +110,22 @@ InputStream
lucasbru commented on PR #13876:
URL: https://github.com/apache/kafka/pull/13876#issuecomment-1611471103
@jolshan Yes, the main reason for wrapping was consistency. However, I'm now
considering a different kind of consistency - never wrap fatal errors - which
is what was originally
joobisb commented on code in PR #13862:
URL: https://github.com/apache/kafka/pull/13862#discussion_r1245268151
##
docs/quickstart.html:
##
@@ -154,9 +154,9 @@
By default, each line you enter will result in a separate event
being written to the topic.
jeqo commented on PR #13923:
URL: https://github.com/apache/kafka/pull/13923#issuecomment-1611480623
@divijvaidya adding the following changes to the KIP:
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=97554472=363=362
--
This is an automated message from the
1 - 100 of 101 matches
Mail list logo